fix([issue-6210]): layer the claim-work reviewer override into the JIRA play-button prompt - #6212
Merged
Conversation
…RA play-button prompt resolveClaimReviewerPrompt resolved the Code Review Defaults alone, so a reviewer chain pinned for claims reached GitHub/GitLab/PLAN.md runs but silently not JIRA ones, and GET /api/apps/:id/claim-reviewers previewed a chain the JIRA run would not use. It now takes the app and layers claim-work metadata over the defaults through the same claimReviewersFrom the scheduled path uses; buildJiraTicketTask passes its app through.
… default claim path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shipped issue #6210.
Closes #6210
What
resolveClaimReviewerPrompt()inserver/services/cosTaskGenerator.jsresolved the Code Review Defaults alone ({}), so a reviewer chain pinned for claims reached GitHub/GitLab/PLAN.md runs but silently not JIRA play-button claims — andGET /api/apps/:id/claim-reviewerspreviewed a chain the JIRA run would not use. It now takes the app and layers claim-work metadata over the defaults through the sameclaimReviewersFromthe scheduled path uses;buildJiraTicketTaskpasses its app through.Test plan
services/cosTaskGenerator.test.js: 154 passed — JIRA assembly now asserts the override wins (codex,claude,@alice) and falls through to defaults (ollama,@alice) when claim-work pins no list; source guards pinresolveClaimReviewerPrompt(app)and ban the bare-{}call.routes/cos.test.js+routes/cosTaskRoutes.test.js+routes/apps/taskTypes.test.js: all pass (355 total across the four files);cos.test.jsapps mock gainedgetAppTaskTypeOverridessince the route now exercises it.lib/reviewerConfig.test.js+lib/cosValidation.test.js: 96 passed.