DISORT/VDISORT overhaul - #1163
Open
riclarsson wants to merge 84 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR written mostly by AI (ChatGPT 5.6 Sol) with my guidance to ensure that existing and known tests are working (and that there is consistency between DISORT and VDISORT). Below is what it considers done, missing, and requests from a review.
My main gripe is I need the VDISORT test suite. I have set up some simple tests for known physics, like simple Fresnel-to-Brewster and Rayleigh at 90 deg. But I do not have a wide enough range of tests to confirm if this is working in all ways we want, so there is no user facing VDISORT code.
Done:
Missing:
Requests: