Transmission matrix - #1162
Open
riclarsson wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
@stefanbuehler There is a typo in the ARTS 2.6 paper by me. I messed up some square roots. Eq. (7) x^2 and y^2 should not have square roots around their numbers. I implemented it from the paper for ARTS3 (the ARTS2 version does not make the error as far as I can see). |
Contributor
|
Thanks for finding this and pointing it out. Is the correct equation written down somewhere (for ARTS3)? We could do an erratum for the paper, but I'm a bit afraid of the overhead that that process will likely cost, if we do it through the journal. Or perhaps we could make an errata section in the main .md file for ARTS 2.6? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some extra ways to compute the transmission matrix. It also seem to fix a bug in my expm code. This error might affect ARTS2.