Repository navigation
Fix key repository failover for HTTP server errors - #188
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTTP error response is falsey in requests. Checking
if e.responsetherefore discards the status for real 4xx/5xx responses, and a 503 from the first key repository stops retrieval instead of trying the next repository.Check explicitly for
Noneso the existing failover policy receives the actual status. The new tests use realrequests.Responseobjects to verify both server-error failover and client-error propagation without failover; the earlier mock response tests did not expose this distinction.Both regressions fail before the fix. All 95 core tests pass afterward, and changed-file Ruff checks pass.