Refresh dashboard and harden daemon with Effect services - #1
Draft
atimmer wants to merge 3 commits into
Draft
Conversation
Preserve existing success-notification behavior while adopting @24letters/ui. Serialize storage and lifecycle operations, validate daemon identity, and scope requests and background work with Effect. Add isolated regression tests and mini-verified preview fixtures; keep live runtime and global links unchanged.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating on behalf of Anton (GPT-6-Astra)
Concurrent lifecycle and storage operations could lose updates, allocate duplicate ports, or stop unrelated services. This change introduces Effect services with serialized transactions, explicit daemon/session ownership, cancellable requests and background work, and shutdown that drains cleanup before releasing locks. CLI mutations verify daemon identity and decode responses.
The dashboard now uses
@24letters/ui, with responsive navigation, accessible forms and confirmations, reliable log following/reconnection, and distinct connection-error states. Existing workspace notes and the success-notification behavior are preserved.Validation: 179 guarded tests, full build, typecheck and lint; seven in-memory preview tests; independent Astra reviews and Fable desktop/mobile browser verification on the mini. Review screenshots are versioned. All work and builds stayed in the isolated checkout; the live daemon, global CLI links and original checkout were not changed.
Operational notes: Effect is pinned to 4.0.0-rc.112. Cooperating daemons enforce one owner of the shared tmux session; stale ownership directories after crashes require explicit cleanup. Existing service panes survive graceful daemon shutdown. This branch has not been deployed or merged.