Repository navigation
Rename Project::getVersions() to fetchVersions(), Deprecate Project::getVersions() - #22
Merged
Merged
Conversation
pavog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project::getVersions()sends a request to the SpigotMC API, but its name looks like a getter of the generated model. Methods that send a request are now prefixed withfetch, so it is clear when the client calls the API.Changes
Project::fetchVersions(). It has the same parameters and returns the samePaginatedVersionList. The PHPDoc states that it sends a request on every call and that the result is not cached.Project::getVersions()is deprecated and callsfetchVersions(). It will be removed in the next major version.fetchVersions(). A new test checks that the deprecatedgetVersions()still fetches the versions.This is not a breaking change.