Repository navigation
⚠️ !Breaking Change! Extend the generated models in the wrappers, remove getData() - #21
Merged
Merged
Conversation
# Conflicts: # tests/Unit/Client/VersionTest.php
# Conflicts: # tests/Unit/Client/VersionTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrappers
Project,VersionandAuthornow extend the generated models instead of wrapping them. All getters of the models can be called on the wrappers directly, sogetData()is no longer needed:Breaking changes
Project had two methods with the same name as getters of the model. The model getters take precedence now:
The previous behaviour is available under new names:
Removed
getData()is removed. Call the getters on the wrapper directly instead, e.g.$project->getTitle()instead of$project->getData()->getTitle().Tests and README