Repository navigation
Name test fixtures after the operationId of their endpoint - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit test fixtures were named in snake_case with a
_responsesuffix, e.g.get_project_response.json. They are now named after the operationId of the endpoint they belong to, e.g.getProject.json, so the fixture for an endpoint can be found directly from the generated API method.get_notification_response.jsongetNotification.jsonget_payout_history_response.jsongetPayoutHistory.jsonget_project_dependencies_response.jsongetDependencies.jsonget_project_response.jsongetProject.jsonget_report_response.jsongetReport.jsonget_team_members_response.jsongetTeamMembers.jsonget_thread_response.jsongetThread.jsonget_thread_without_references_response.jsongetThreadWithoutReferences.jsonget_user_response.jsongetUser.jsonget_version_response.jsongetVersion.jsonget_version_without_dependencies_response.jsongetVersionWithoutDependencies.jsonsearch_projects_response.jsonsearchProjects.jsonget_forge_updates_response.jsonandget_statistics_response.jsonwere not used by any test and are removed.Only tests are changed. All unit tests pass with the same number of assertions as before.