Repository navigation
⚠️ !Breaking Change! Prefix wrapper methods that send a request with fetch - #33
Merged
Merged
Conversation
JulianVennen
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several wrapper methods started with
getalthough they send a request to the Modrinth API every time they are called, e.g.$version->getProject(). This is easy to miss, because they look like the getters of the generated models.All wrapper methods that send a request now start with
fetch. The old names are removed, not deprecated. The PHPDoc of each method states that it sends a request every time it is called. The README explains the naming convention.NotificationgetUser()fetchUser()ProjectgetThread()fetchThread()Project,SearchProjectgetDependencies()fetchDependencies()Project,SearchProjectgetMembers()fetchMembers()SearchProjectgetFullProject()fetchFullProject()TeamMembergetTeamMembers()fetchTeamMembers()UsergetProjects()fetchProjects()UsergetNotifications()fetchNotifications()UsergetFollowedProjects()fetchFollowedProjects()UsergetPayoutHistory()fetchPayoutHistory()VersiongetProject()fetchProject()VersiongetAuthor()fetchAuthor()VersionDependencygetProject()fetchProject()VersionDependencygetVersion()fetchVersion()Threads\ReportgetProject()fetchProject()Threads\ReportgetUser()fetchUser()Threads\ReportgetVersion()fetchVersion()Threads\ReportgetThread()fetchThread()Threads\ThreadgetProject()fetchProject()Threads\ThreadgetReport()fetchReport()Threads\ThreadMessagegetAuthor()fetchAuthor()Methods that do not send a request keep their names, e.g.
Version::getDependencies(),TeamMember::getUser(),Thread::getMessages()andThreadMessage::getThread().fetchProjectVersions()andSearchProject::fetchAuthor()already had the right name.