Repository navigation
Use a separate configuration for every client - #32
Merged
Merged
Conversation
JulianVennen
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModrinthAPIClientusedConfiguration::getDefaultConfiguration()when no configuration was passed. That is a process wide singleton, so all clients without an explicit configuration shared it:new ModrinthAPIClient("token-a")followed bynew ModrinthAPIClient("token-b")made the first client sendtoken-bnew ModrinthAPIClient()) removed the token of every other clientsetUserAgent()changed the user agent of all clientsEvery client now creates its own
Configuration. The boolean query string format is still set on the default configuration as well, because theObjectSerializerreads it from there.Breaking changes
Configuration::getDefaultConfiguration()(e.g.setHost()) no longer apply to clients created without a configuration. Pass your ownConfigurationto the constructor instead.