Repository navigation
⚠️ !Breaking Change! Rename ResultList to PaginatedList - #39
Merged
Merged
Conversation
JulianVennen
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base class of all lists,
Client\List\ResultList, is renamed toClient\List\PaginatedList. This is the name used by the other clients (for CurseForge, Modrinth and Spigot).Not renamed
The lists that extend
PaginatedList(e.g.ProjectList,UserList,ProjectVersionList) keep their names.Breaking changes
ResultListis removed. UsePaginatedListin type hints,instanceofchecks and classes that extend it. The old name is not kept as an alias, because this is part of a major release.foreach,getNextPage()orgetResults(), is not affected.Tests and README
ResultListTestis renamed toPaginatedListTest. The integration tests usePaginatedList.