Repository navigation
⚠️ !Breaking Change! Extend the generated models in the wrappers, remove getData() - #24
Merged
Merged
Conversation
JulianVennen
requested changes
Oct 19, 2026
JulianVennen
left a comment
Member
There was a problem hiding this comment.
Why not just remove getData completely instead of deprecating it? We have done the same for the modrinth client
JulianVennen
approved these changes
Oct 19, 2026
getData()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrappers
Category,File,Game,GameVersionTypeandModnow extend the generated models instead of wrapping them. All getters of the models can be called on the wrappers directly, sogetData()is no longer needed:None of the wrapper methods has the same name as a getter of its model, so all existing methods keep their behaviour.
Breaking changes
getData()is removed from all wrappers. Call the getters on the wrapper instead, e.g.$mod->getName()instead of$mod->getData()->getName(). Wrappers can be passed wherever a model is expected, because they are instances of it.Tests and README