[pavog]

Clients created without a configuration used Configuration::getDefaultConfiguration(), which is a process wide singleton. All of these clients therefore shared one configuration:

$first = new CurseForgeAPIClient("first-api-token");
$second = new CurseForgeAPIClient("second-api-token");

$first->getGame(432); // was sent with "second-api-token"

The same applied to the user agent: calling setUserAgent() on one client changed it for all other clients.

Changes

• CurseForgeAPIClient: creates a new Configuration() if none is passed, instead of using the default configuration.
• Tests: two new tests check that clients without an explicit configuration do not share the API token or the user agent, and that an explicitly passed configuration is used. The test helper no longer passes its own configuration, so the default path is covered by all client tests.
• setConfiguration() still sets the boolean query string format on the default configuration, because the generated ObjectSerializer reads it from there.

Behavior change

Changes made to Configuration::getDefaultConfiguration() (e.g. host or debug settings) no longer affect clients that are created without a configuration. To customize the configuration, pass it to the constructor:

$client = new CurseForgeAPIClient("api-key", $configuration);

[JulianVennen]

This is probably a breaking change