馃悰 Stop config file watcher on client shutdown - #12
Merged
JulianVennen merged 1 commit intoAug 13, 2026
Conversation
NightConfig's default FileWatcher keeps a non-daemon executor thread alive after the Minecraft client has finished shutting down. This prevents the JVM from terminating normally and eventually triggers Minecraft's client shutdown watchdog. Add a common shutdown hook that stops the default FileWatcher and invoke it in all stop lifecycle events. This ensures the configuration watcher is terminated before the client exits and prevents the shutdown watchdog crash.
|
|
Member
|
Weird, this doesn't seem to be an issue in the dev environment for some reason, but I can reproduce it in prism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NightConfig's default FileWatcher keeps a non-daemon executor thread alive after the Minecraft client has finished shutting down. This prevents the JVM from terminating normally and eventually triggers Minecraft's client shutdown watchdog.
Add a common shutdown hook that stops the default FileWatcher and invoke it in all stop lifecycle events.
This ensures the configuration watcher is terminated before the client exits and prevents the shutdown watchdog crash.