fix: support native array methods on collections - #1217
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
AayushSaini101
requested review from
asyncapi-bot-eve,
magicmatatjahu and
princerajpoot20
as code owners
August 6, 2026 07:54
🦋 Changeset detectedLatest commit: cf16e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
❌ The last analysis has failed. |
princerajpoot20
approved these changes
Aug 6, 2026
Contributor
|
@asyncapi/microgrant_team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #874
Summary
.map(),.filter(),.slice()) onCollectionsubclasses such asSecurityRequirementsCollectionthen doessuper(...collections)and throwsSymbol.speciestoArrayso transforms return plain arrays (same pattern asall()/filterBy())Problem
Workaround today:
securityRequirements.all().map(...).This affects every
Collectionsubclass (Servers,Channels,Messages,SecurityRequirements, …), not only security.Solution
In
packages/parser/src/models/collection.ts:Native transforms no longer reconstruct a
Collectionwith an invalid constructor signature.Test plan
collection.spec.ts—.map()/.filter()/.slice()return plain arrays; source/meta()unchangedsecurity-requirements.spec.ts—.map()does not throw (issue reproduction)all,filterBy,get,has) still passChangeset
Patch for
@asyncapi/parser:fix: support native array methods on collectionsReferences