perf(julia_helpers): check for Julia functions with isa - #1395
Merged
MilesCranmer merged 2 commits intoSep 28, 2026
Merged
Conversation
Call `isa(op, Function)` directly instead of compiling a new anonymous Julia function for each validation. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
MilesCranmer
approved these changes
Sep 28, 2026
MilesCranmer
enabled auto-merge (squash)
September 28, 2026 08:54
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
MilesCranmer
approved these changes
Sep 28, 2026
MilesCranmer
approved these changes
Sep 28, 2026
MilesCranmer
disabled auto-merge
September 28, 2026 18:09
MilesCranmer
enabled auto-merge (squash)
September 28, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PySR changes pair with the SymbolicRegression.jl PRs astroautomata/SymbolicRegression.jl#739 through #742, which compile PySR's search and PythonCall conversions at install time. Each PySR PR works on its own with the current SymbolicRegression.jl. The full speedup arrives once those PRs are released and PySR's version bound is raised.
Why
jl_is_functionevaluated a new anonymous Julia function (op -> op isa Function) each time it was called, and Julia compiled each one. Callingisadirectly avoids that.Scope
pysr/julia_helpers.py:jl_is_functioncallsjl.isa(f, jl.Function).Verification
Zero-iteration first fit 2.91 s to 2.83 s. The README example's first fit did not change beyond noise.
With all seven PRs applied, on a 12-core Slurm node (Julia 1.13.1, Python 3.13), the README example's first fit went from 17.4 s to 6.95 s, and a zero-iteration first fit from 12.6 s to 2.71 s.
pysr/test/test_main.pyandpysr/test/test_type_specs.pypass (254 passed, 1 skipped). The pre-commit hooks pass.