Skip to content

Use Namespace runners for applicable Windows builds #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaniebot wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −8
Open

Use Namespace runners for applicable Windows builds #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b36002
Use Namespace runners for Windows builds
zanieb Sep 9, 2026
138d87e
Select the Windows crate runner through find_runner
zanieb Sep 10, 2026
9b4bc7c
Use the matching runner for every crate build
zanieb Sep 10, 2026
fb081b4
Explain the Linux crate runner compatibility requirement
zanieb Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ci-matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,10 @@ def generate_crate_build_matrix_entries(
{
"platform": platform,
"arch": arch,
# Use the GitHub runner for Windows, because the Depot one is
# missing a Rust toolchain. On Linux, it's important that the the
# `python-build` runner matches the `crate-build` runner because of
# GLIBC version mismatches.
"runner": find_runner(
runners, platform, arch, True if platform == "windows" else False
),
# Linux distribution jobs execute the uploaded `pythonbuild` binary.
# Select the same runner to avoid requiring a newer glibc than the
# consumer has.
"runner": find_runner(runners, platform, arch, False),
"crate_artifact_name": crate_artifact_name(
platform,
arch,
Expand Down
2 changes: 1 addition & 1 deletion ci-runners.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ macos-latest:
platform: darwin
free: true

depot-windows-2022-8:
namespace-profile-windows-2022-x86-64-16x32:
arch: x86_64
platform: windows
free: false
Expand Down
Loading