ci: split Fleet status so no job is skipped - #94
Merged
Merged
Conversation
The self-test and backfill jobs shared a workflow with the status job, so every review, comment and workflow_run event added two skipped checks to the PR. Each now has its own workflow with only the trigger it runs on. self-test runs only when a PR changes a file its tests read, and the status workflow re-posts the lanes when it completes.
sprayberry-redline
approved these changes
Sep 26, 2026
sprayberry-redline
left a comment
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. Moves the self-test and backfill jobs into their own workflows with only the trigger each runs on, so the status workflow's review, comment and workflow_run events no longer produce skipped checks. The moved jobs are byte-for-byte the old ones with the same scoped permissions and pinned actions; the new self-test workflow triggers on pull_request and is added to the status workflow's workflow_run list, which is exactly what the existing trigger test enforces, and the backfill limit test now reads the file the backfill lives in.
github-actions
Bot
added
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet status ran three jobs from one workflow: status, self-test (pull_request only) and backfill (workflow_dispatch only). Every pull_request_review, issue_comment and workflow_run event therefore added two skipped checks to the PR. This splits it so each workflow runs one job on each event it fires on.
Changes:
fleet-status.ymlkeeps only the status job and its triggers, minus workflow_dispatch. Its workflow_run list gains "Fleet status self-test", because that workflow runs on pull requests like every other workflow the list names.fleet-status-self-test.yml(new, "Fleet status self-test") runs theself-testjob on pull requests that change a file its tests read: the fleet-status script, its test, or a workflow file (the test checks every workflow's triggers against the workflow_run list). self-test is not a required check on the default branch here, so a PR outside those paths simply has no self-test run. The required checks are unchanged.fleet-status-backfill.yml(new, "Fleet status backfill") holds the manual backfill job, workflow_dispatch only.fleet/verify and fleet/review are commit statuses posted by the script, which is unchanged, so no required check changes name. The test passes and the workflows pass actionlint.