Repository navigation
fix(config): fail closed when selected policy cannot load - #223
Merged
Merged
Conversation
Treat explicit selection as required, retain unusable discovered paths, expose load states and redact runtime diagnostics. Verify the real route/serve boundaries and prove forbidden fallback destinations are never contacted. Clarify must-use stream annotations for the current compiler lint gate. [design:WF-DESIGN-0022] Signed-off-by: Tom Ballard <tom@armytage.co>
tcballard
force-pushed
the
codex/fail-closed-config
branch
from
October 5, 2026 08:54
86d2af4 to
af7ab6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly selected missing configuration previously became optional defaults, and discovery skipped unusable paths. Fail at the selected policy boundary instead, for both routing and initial gateway startup.
This is the Wayfinder portion of the 5 October policy-hardening workstream. It is independent of the decision-engine experiment in #222.
Scope
must_useannotations for current Rust lint compatibility, matching feat(experiment): compare decision engines behind an opt-in boundary #222.Findings and source verification
Confirmed loading defects: explicit-missing/default substitution and skipped unusable config discovery. A gateway may already fail later for missing models; this patch removes reliance on that side effect.
Claude Code releases verify
allowedProvidersand managed-settings read handling in 2.1.285, plus the compound-command, symlink read-denial, MCP metadata and shell-variable fixes in 2.1.289. These prompted the audit; they are not claimed as Wayfinder vulnerabilities.Wayfinder already enforces model-alias allowlists and destination privacy/locality checks during fallback. The new regression protects that behaviour. Claude's provider setting is not imported: protocol kind does not identify every provider host. Operators must restrict all relevant aliases and control their deployment endpoints.
Shell approvals, IDE file permissions and third-party MCP metadata integrity remain host-agent responsibilities.
Verification
Passed on Linux:
cargo +stable fmt --manifest-path rust/Cargo.toml --all -- --checkcargo +stable test --manifest-path rust/Cargo.toml --workspace --all-features --locked— 587 tests passedcargo +stable clippy --manifest-path rust/Cargo.toml --workspace --all-targets --all-features --locked -- -D warningsnode clients/shared/test/parity.mjs— 21/21 score, route and feature checksCompatibility and limits
An explicit missing config now errors instead of silently selecting defaults. Valid symlinks remain supported. Failed live reloads retain the last validated snapshot; existing requests finish on their captured snapshot. Protect config directories from untrusted writes: this is not an atomic filesystem sandbox.
No native Apple UI changes or live Claude Code qualification. The host must be updated independently.
Checklist