Skip to content

Second audit: record the findings, fix the published state, document the remaining tasks - #16

Merged
asamarts merged 23 commits into
mainfrom
second-audit-remediation
Nov 19, 2026
Merged

asamarts merged 23 commits into
mainfrom
second-audit-remediation

Conversation

@asamarts

@asamarts asamarts commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Records the second audit of 2026-11-18, fixes what it found in the published state, and documents every remaining audit task. Nothing here is a release: the fixes ship with 0.6.0 (W10-069).

Fixes

  • Action (W10-039): hyphenated inputs (diff-old, diff-new, diff-check, github-token) are read under the names the runner exports, so the diff step runs. The token is sent only to the latest-release query; release assets are downloaded without credentials.
  • Release scripts (W10-040, W10-041): CI's Action references may stay on the previous release only until the new tag is published; the semver and protobuf baselines come from the published release tags; ci/buf-history-skip records a release the history gate cannot install.
  • Documentation (W10-042, W10-043): the quickstart and evolution sequences run as written and are tested, the test applies the guide's contract change, and the documented CI snippets run witforge diff as a separate step so that moving the Action pin does not start gating by surprise.
  • Tests: cargo test now runs ci/test-release-version.sh and action/test.js (crates/witforge-cli/tests/tooling.rs), so the tasks that changed them close on a test.

Plan

  • 61 audit tasks (W10-038 to W10-098, W11-038, W11-039) and the audit record docs/design/audit-2026-11-18-second.md.
  • Every open audit task has Why, Edge cases, and Acceptance criteria; a Decision section says whether the owner decided or a default was chosen while documenting (aplan/README.md, Task bodies).
  • 0.6.0 (W10-069) is blocked by 36 tasks, including W10-070, W10-072, and W10-074.

Checked locally

cargo fmt --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --locked on stable and 1.88, cargo doc with -D warnings, ci/check-generated.sh, ci/check-release.sh, ci/check-release-freeze.sh, the three ci/test-release-*.sh suites, node --test action/test.js, shellcheck 0.11.0, actionlint 1.7.8, and aplan check, verify, export-agents-md --check, check-docs.

Hosted CI on this pull request added one fix: the Action's timeout test relied on a timer that does not keep the event loop alive before Node 24, so it was cancelled on the macOS and Windows runners. main has the same defect; it never showed because CI ran the suite only on Linux.

W10-039 is closed on the hosted "workflows and scripts" log of run 44589934230, which shows the Action running witforge check and witforge diff in the reporting step and witforge diff … --check failing in the gate step.

@asamarts
asamarts merged commit a2202ff into main Nov 19, 2026
18 checks passed
@asamarts
asamarts deleted the second-audit-remediation branch November 19, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant