Repository navigation
Second audit: record the findings, fix the published state, document the remaining tasks - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the second audit of 2026-11-18, fixes what it found in the published state, and documents every remaining audit task. Nothing here is a release: the fixes ship with 0.6.0 (
W10-069).Fixes
W10-039): hyphenated inputs (diff-old,diff-new,diff-check,github-token) are read under the names the runner exports, so thediffstep runs. The token is sent only to the latest-release query; release assets are downloaded without credentials.W10-040,W10-041): CI's Action references may stay on the previous release only until the new tag is published; the semver and protobuf baselines come from the published release tags;ci/buf-history-skiprecords a release the history gate cannot install.W10-042,W10-043): the quickstart and evolution sequences run as written and are tested, the test applies the guide's contract change, and the documented CI snippets runwitforge diffas a separate step so that moving the Action pin does not start gating by surprise.cargo testnow runsci/test-release-version.shandaction/test.js(crates/witforge-cli/tests/tooling.rs), so the tasks that changed them close on a test.Plan
W10-038toW10-098,W11-038,W11-039) and the audit recorddocs/design/audit-2026-11-18-second.md.Why,Edge cases, andAcceptance criteria; aDecisionsection says whether the owner decided or a default was chosen while documenting (aplan/README.md, Task bodies).W10-069) is blocked by 36 tasks, includingW10-070,W10-072, andW10-074.Checked locally
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace --lockedon stable and 1.88,cargo docwith-D warnings,ci/check-generated.sh,ci/check-release.sh,ci/check-release-freeze.sh, the threeci/test-release-*.shsuites,node --test action/test.js,shellcheck0.11.0,actionlint1.7.8, andaplan check,verify,export-agents-md --check,check-docs.Hosted CI on this pull request added one fix: the Action's timeout test relied on a timer that does not keep the event loop alive before Node 24, so it was cancelled on the macOS and Windows runners.
mainhas the same defect; it never showed because CI ran the suite only on Linux.W10-039is closed on the hosted "workflows and scripts" log of run 44589934230, which shows the Action runningwitforge checkandwitforge diffin the reporting step andwitforge diff … --checkfailing in the gate step.