update process_fdn fucntion: add positional filter arguments - #202
Open
almahova wants to merge 2 commits into
Open
update process_fdn fucntion: add positional filter arguments#202almahova wants to merge 2 commits into
almahova wants to merge 2 commits into
Conversation
…pt td objects (post_delay, post_matrix, post_output). update all declerations
SebastianJiroSchlecht
approved these changes
Jul 30, 2026
SebastianJiroSchlecht
left a comment
Collaborator
There was a problem hiding this comment.
I have read all the changes, and I think they are good as is. I have not executed the code, though. It's ok to merge in my view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add positional filter arguments to
process_fdn()function. The function now accepts td objects:post_delay: Any | None = None,
post_matrix: Any | None = None,
post_output: Any | None = None,
Update every declaration related to
process_fdn()function.Testing
pytestpasses locallypytest --cov=pyFDN)Checklist
pre-commit run --all-files)HISTORY.rstupdated if this is a user-facing change