feat: Add transactional method to manage closures within transactions#99
Merged
Conversation
sidler
previously approved these changes
Jun 8, 2026
romankonz
reviewed
Jun 9, 2026
romankonz
previously approved these changes
Jun 9, 2026
transaction method to manage closures within transactionstransactional method to manage closures within transactions
sidler
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
transactional()method toConnectionthat runs aClosureinside a database transaction, committing on success and rolling back on anyThrowablebefore rethrowing. This removes the need for callers to manually pairbeginTransaction()/commit()/rollBack()around their logic.Changes
src/Connection.php: Implementstransactional(Closure $callback): mixed. Begins a transaction, invokes the callback, rolls back and rethrows onThrowable, otherwise commits and returns the callback's result.src/DoctrineConnectionInterface.php: Adds thetransactional()method to the interface with a generic@template TReturnannotation so the return type is preserved for static analysis.src/MockConnection.php: Provides a no-op implementation that simply invokes the callback (no real transaction handling needed in tests).Usage