Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fix the actual CodeQL TOCTOU report at server/main.c:87 in parent PR #2 (check115329964830). No suppression is added.
Validation
24 isolated Linux synthetic fixtures passed. The harness extracts the actual production random_seed/host_seed functions and compiles only those with -std=c99 -Wall -Wextra -Werror -O2. It does not build or launch the daemon.
Coverage includes existing-key reuse, deterministic parent-path swaps during reuse/create/write-error cleanup, symlink parent (including repeated separators), seed symlink/FIFO/directory/length/mode/owner rejection, concurrent creator, short/EINTR I/O, entropy/read/write/file-fsync/close errors, and directory-fsync failure retaining the complete identity.
No real keys were accessed or exported. No full source/CMake/Yocto/Vivado build, board/network/UART/JTAG access, manual CI dispatch, merge, or recipe/source-pin change was performed. Automatic PR checks must confirm CodeQL disposition; focused fixtures are not full-server or board qualification.
Stack and deployment
Base feat/mpunoxv-interactive-sshd at a397eb9 (parent PR #2). Keep the existing BSP source pins and board binary until a separately built successor is tested. Existing persistent host seed is reused; no rekeying/migration is required.