docs: Google ADK Guard (JS and Python) and Cloudflare Think - #948
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review of Content looks good. Both Related cites check out: Think points at CI is green on this head after refreshing the Think light/dark screenshots from CI actuals (the only deterministic Playwright failure). #920 is already closed as superseded. |
There was a problem hiding this comment.
Arcjet Review — 🔴 High Risk
Decision: Blocked
Rationale: PR has merge conflicts. Resolve conflicts before review.
Review: 9a6f0156 | Powered by Arcjet Review
There was a problem hiding this comment.
Arcjet Review — 🟢 Low Risk
Decision: Approved
Rationale: Documentation-only PR adding new guard pages for Cloudflare Think and a tabbed JS/Python page for Google ADK, plus supporting sidebar/switcher/redirect entries and refreshed screenshots. The previous blocking merge conflict was resolved via the 'merge: bring main into the ADK and Think docs branch' commit. Code changes are additive entries in framework/SDK maps and a new SVG icon component; the two workflow edits only add workflow_dispatch triggers, which is a low-risk convenience. No secrets, no auth/infra logic, no schema changes. PR is >1000 lines but almost entirely MDX/snippets/PNG snapshots — low risk despite size.
Summary of Changes
Adds a new /guards/cloudflare-think/ page and merges Google ADK JS + Python into a single tabbed /guards/google-adk/ page (superseding the split /guards/google-adk-py/). Wires the two into the framework switcher, sidebar, SDK registry, get-started, quick-start, framework-integrations index, Python reference, and llms.txt/llms-full.txt. Adds a Simple-Icons Cloudflare mark icon component, get-started + quick-start snippets for both, screenshot baselines, sdk.test.ts assertions, vercel.json redirects from old /guards/google-adk-py/ and /sdk/google-adk-py/* URLs, and workflow_dispatch triggers on the Playwright and spellcheck workflows.
Escalation Triggers
- CI/CD Pipeline: playwright.yml and spellcheck.yml each add a
workflow_dispatchtrigger. Low-impact convenience change, no secrets or permissions touched.
Notes
PR exceeds the 1000-line size threshold, but the bulk is MDX prose, JSON redirect entries, and binary screenshot baselines — all straightforward to review. Previous blocking issue (merge conflicts) has been resolved by the merge commit from main.
Review: 49a6f2a7 | Model: anthropic/claude-opus-4-7 | Powered by Arcjet Review
|
Review of
Redirects and listings: PASS. Actor/inputs and cites: PASS. The merged page still teaches actor and inputs. The Python pin is still CI on Nit: Playwright and spellcheck now allow |
|
Review of David’s content requirements: PASS.
CI on All six review threads are resolved. |
Document the unpublished Python Google ADK and JS Cloudflare Think adapters from current main, with git SHA pins, actor/inputs teaching, and framework switcher wiring. Does not change the live JS Google ADK page. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Regenerate Playwright snapshots for the new Guard pages, framework switcher surfaces, and llms.txt listings. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Point Related at examples/cloudflare-think-agent on david/cursor/cloudflare-think-agent-f8cc at 48d4e54c. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Related now cites the landed examples/cloudflare-think-agent branch. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Playwright shards failed on ~800-pixel diffs for the Think page light/dark snapshots. Replace them with the CI-captured actuals. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Fold the Python ADK guide into /guards/google-adk/ with language tabs, redirect the retired google-adk-py routes, and use the official Cloudflare mark on the Think switcher chip. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
The david/cursor/google-adk-guard-5549 branch was deleted after merge. Link the install pin to the a71970dc tree, leave the pin SHA unchanged, and refresh the Playwright snapshots that changed with the Cloudflare mark, the merged ADK tabs, and the footer pixel diffs. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
The snapshot commit reached the PR but did not create GitHub Actions runs. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Pushes after the snapshot commit did not create GitHub Actions runs. workflow_dispatch lets those checks be started on this branch. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
Declare a placeholder Env, build Think hooks for the user on that call, and split the Think install command across package managers. Link guard_action to the Python SDK reference, record why Playwright dispatch stays open to any branch, and drop the deleted Think adapter branch link. Pin SHAs stay the same. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
The guide install block is now package-manager tabs with the git pin on its own line, and the deleted adapter branch link is gone. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
The dedicated /guards/google-adk-py/ page was folded into the tabbed google-adk guide; these snapshots were left untracked by that rename. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
07951ab to
272d716
Compare
The rebase conflict kept PR-era quick-start snapshots that predate main's Microsoft Agent Framework Go tab. Replace both light and dark linux snapshots with the CI actuals from the failed shard. Co-authored-by: David Mytton <davidmytton@users.noreply.github.com>
|
Post-rebase re-verify
|
|
Final confirm after rebase
|
Documents Google ADK Guard for JS and Python on one tabbed
/guards/google-adk/page, and adds Cloudflare Think Guard at/guards/cloudflare-think/.@arcjet/guard/google-adk/v2and Pythonarcjet.guard.google_adk/arcjet[google-adk]behind Strands-style language tabs. Retired/guards/google-adk-py/(old URLs redirect).@arcjet/guard/cloudflare-think/v0, with the official Cloudflare mark in the framework switcher.llms.txt, redirects, and Playwright snapshots.Until publish: Python ADK pin
a71970dc; Think pinb06e584d.Supersedes #920.