[4.x] Laravel 13.24 support (fix #1474) - #1476
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes update tenant command signatures, Laravel-version-specific command construction, constructor argument forwarding, and a PHPStan suppression in the tenancy service provider. ChangesTenant command compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6f4e6fc to
e38dfb7
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Commands/Seed.php`:
- Around line 21-33: Update the constructor logic in the command class so the
Laravel 13.24+ branch only assigns the signature, removes the
specifyParameters() call, and then invokes parent::__construct($resolver) after
the version-specific setup. Preserve the legacy branch’s name assignment and
ensure the parent initializes parameters from the signature without redefining
the database option.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0b0f723e-1713-421f-b9c6-2d2539008068
📒 Files selected for processing (4)
src/Commands/Run.phpsrc/Commands/Seed.phpsrc/Concerns/HasTenantOptions.phpsrc/TenancyServiceProvider.php
- We conditionally use either $signature + specifyParameters() in the newer versions or just $name in the older versions. There doesn't appear to be a single solution that'd work in both versions, likely having to do with the constructor override in the trait and how the specifyParameters() method behaves differently in this class between versions - Remove unnecessary options from the Run command (the trait adds those) - Not directly related: make HasTenantOptions accept ...$args - Unrelated: remove phpstan ignore in TenancyServiceProvider
e38dfb7 to
f5f5a44
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
============================================
+ Coverage 86.63% 86.65% +0.02%
- Complexity 1219 1220 +1
============================================
Files 186 186
Lines 3583 3589 +6
============================================
+ Hits 3104 3110 +6
Misses 479 479 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
newer versions or just $name in the older versions. There doesn't
appear to be a single solution that'd work in both versions, likely
having to do with the constructor override in the trait and how the
specifyParameters() method behaves differently in this class between
versions
Summary by CodeRabbit
tenants:runcommand interface by removing tenant selection options.