Skip to content

Roll back script state when a service route collides #537

Description

@dajiaohuang

Service route hostnames are derived through lossy normalization, so distinct configured names can map to the same host. In openScriptAsync, the new PTY is inserted into state.running before
outes.register can throw on that collision; the failure path does not close the PTY or remove the running entry. Reproduce by starting two services whose names normalize to the same hostname. The second start reports failure but leaves a running entry/process behind and cannot be retried normally. Validate/reserve the route before spawning, or roll back both the route and process state on failure.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions