Repository navigation
feat(App-1355): Introduce Safe accounts in top-level pages - #1496
Merged
Conversation
|
🚀 Preview Deployment: View Here |
Fabricevladimir
changed the title
|
E2E results (preview) Smoke
|
milosh86
approved these changes
Oct 16, 2026
milosh86
left a comment
milosh86
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍 .... comments and specs are becoming unreadable though, we will need to trim this at some point.
|
|
||
| Companion notes: [`createWorkspace.md`](./createWorkspace.md) (the implementation of record), | ||
| [`workspaceRouting.md`](./workspaceRouting.md) (the account-scope ADR), | ||
| [`workspaceAccess.md`](./workspaceAccess.md) (registry/auth, orthogonal to this). |
Contributor
There was a problem hiding this comment.
workspaceAccess.md is doc Claude committed by mistake, it will be removed.
Contributor
There was a problem hiding this comment.
let's just remove reference.
milosh86
merged commit Oct 19, 2026
f480f2d
into
app-1140-v1-of-workspaces-supporting-multiple-daos
10 checks passed
milosh86
deleted the
app-1355-introduce-safe-account-in-top-level-aggregation-pages
branch
October 19, 2026 09:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes Safe accounts first class citizens in workspaces.
Safes are account options.
useWorkspaceAccountOptionsno longer filters to DAOs and resolvesthe active option through
workspaceUtils.findAccountById(network + address) rather than comparingID strings, so a Safe route or a lowercased shared link both land on their account instead of
widening to the whole workspace. It is now the single resolver: the assets, transactions and
proposals pages dropped their own route lookups.
Assets and Transactions are now supported for Safes with the rest of the top-level pages coming after.
Things to note
Because Assets and Transactions have dropped their gates, a known issue is that an invalid DAO account or non-existent Safe account, will resolve on these pages. This will be handled in a subsequent PR
Safe support can now be found in
createWorkspace.mdA dedicated file,
workspaceSafeAccounts, has working assumptions and solutions for workspace integration.Type of Change
Developer Checklist:
Review Checklist: