Repository navigation
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
…o app-1342-edit-workspace-default-workspace-and-edit-page
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
| } | ||
|
|
||
| const workspace = workspaces[id]; | ||
| const workspace = this.getStoredWorkspacesOrDefault()[id]; |
There was a problem hiding this comment.
How does a fresh user reach the seeded workspace here? The routes need an ID before this lookup runs, but the default's random ID is only created inside it, so opening a workspace page with empty storage still lands in WorkspaceGate's error state.
There was a problem hiding this comment.
yeah true. Now it will show not-found page and then you need to select default workspace which is automatically created.
This mechanic of handling not-found workspace will be addressed in the follow up ticket APP-1343.
Good point anyway, I will think more if this is the right way to create default workspace. This will be in the scope of APP-1343.
Fabricevladimir
left a comment
There was a problem hiding this comment.
Nice job! Minor comments here
Signed-off-by: Milos Dzepina <milos@aragon.org>
Description
Makes local workspaces editable and makes sure there is always a workspace to use. Linear: APP-1342
/workspace/{id}/edituses the same wizard as Create workspace (details → targets → accounts) in the full-screen wizard layout. Create and edit share oneWorkspaceWizardcomponent. It opens from "Edit workspace" in the workspace selector, and from "Add accounts" on an empty workspace's overview, which goes straight to the accounts step (?step=ACCOUNTS).workspaceServicenow uses plainasyncmethods.ownerfield is removed. Creating or editing a workspace no longer needs a connected wallet, and create and update share one publish dialog. An avatar that wasn't changed keeps its stored image instead of being uploaded again.(workspacePage)route group, soedit/can use the wizard layout instead of the workspace navigation. URLs are unchanged.WizardRoot/WizardPage.Containeraccept an optionalinitialActiveStep. Without it, wizards behave as before.createWorkspace.mdupdated.Type of Change
Developer Checklist:
Review Checklist: