feat(APP-1165): Add native Safe governance proposals by thekidnamedkd · Pull Request #1437 · aragon/app

thekidnamedkd · 2026-09-30T18:58:12Z

Description

Implements APP-1165. Stacked on #1397; base branch is safe-biz-logic.

Safes with DAO Execute permission appear as governance processes. Their Proposals tab pages through stored pending and executed DAO transactions from backend #1587. SAFE-<nonce> labels are display-only; links identify the Safe and transaction hash, so competing transactions remain separate. Old hash links also look up superseded and removed transactions.

Creation uses the action-only wizard. Details show decoded DAO.execute actions and reuse the multisig voting presentation, with Safe envelope review and owner signing inside Aragon. Decoded actions are checked against the transaction's local action tuples; pending or mismatched decoding falls back to raw actions. Process settings and members reuse the Safe-body views. Assets and Transactions are unchanged.

The list verifies DAO.execute targets, including known MultiSend batches, and reports stale, partial or unindexed reads. Pagination remains usable when a backend page has no matching DAO actions or the next request fails. Signing retains fresh queue/history reconciliation and checks the reviewed hash, owner, chain and nonce.

Dependencies: #1397 supplies the Safe review/signing primitives and remains this PR's base. Execute-grant registration, stored transactions and decoded actions are available on dev. The earlier missing-process/404 fixture blocker no longer describes the current fixtures.

Verification updated 2026-10-16

Latest combined local checks passed 473 tests across 42 affected suites, app type-check, changed-file lint and changeset validation. Current-head CI at e13d63207 passes, including tests, deployment, E2E and CodeQL.
Live development checks covered stored pagination, retired transaction states, decoded actions and process-only discovery. The process-only Safe 0xE9C78Ac980BDfE01587FdC9a3ebdfA9243cc5f9f appears in Members with both owners; its owner-detail link preserves the Safe selection after reload.
A connected owner signed SAFE-11 from the native proposal page in the latest preview. Safe 0x8442c05d620e11009bdaEDdefDA3b5303725c39A, transaction hash 0x6f0490872ad26175c9b05bd56b133da65fa363eca6ac3f18458f3751bc723383, now has both owners' confirmations. This fixture has both body and process permissions; the interaction used the native-process route.
No execution was sent for SAFE-11. Its nonce is 11, the Safe's chain nonce remained 9, and the DAO metadata remained unchanged. The page correctly shows Waiting for earlier nonce. APP-1165 requires viewing and signing; executing this particular queued transaction is not required for that check.
The immediate post-sign stored read returned the older one-confirmation snapshot. A browser replay on the unchanged preview verified that the existing 30-second poll updates Votes when the two-confirmation snapshot becomes available. This does not measure live backend catch-up time or identify the historical cache layer.
Earlier browser checks covered the metadata-free wizard, disconnected-wallet connection, filtered-empty pagination and hash-addressed detail navigation. Linked-DAO routing and identity have deterministic coverage.

Live signing on a process-only fixture and a shared-Safe/linked-DAO fixture remain untested. Existing development CSP/Permissions-Policy/WalletConnect warnings remain. No missing backend feature was identified by these checks; review approval and the existing review threads are still open.

Type of Change

Minor: Feature (non-breaking change which adds new functionality)

Developer Checklist:

Review Checklist:

(For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
Confirmed that changes follow the code style guidelines of this project

linear-code · 2026-09-30T18:58:25Z

APP-1165

github-actions · 2026-09-30T19:02:38Z

🚀 Preview Deployment: View Here

github-actions · 2026-09-30T19:08:06Z

E2E results (preview)

Smoke


Base URL	https://app-next-eaigihcsj-aragon-app.vercel.app
Suite	smoke
Playwright result	✅ passed
Summary	86 passed
HTML report	View report
GitHub job	✅ completed

View run #5571

milosh86

just a couple of comments for now, I have more to check

milosh86 · 2026-10-02T08:51:42Z

                link: `${baseUrl}/members`,
                icon: IconType.APP_MEMBERS,
-                hidden: !(isSupported && hasBodyPlugin),
+                hidden: !(isSupported && (hasBodyPlugin || hasSafeProcess)),


should we just mark safe plugin with isBody: true on the backend?

yeah, now after reviewing the previous PR, I get that in the context of a workspace a Safe always is both a process and a body, but in the context of a DAO, it could be one or another. Also it seems that if it has EXECUTE permission and it is added as a process then it should automatically be a body too. In the other case, if it is a body in a SPP process, then it's just a body.

milosh86 · 2026-10-02T13:48:02Z


    const { result, isLoading } = useSimulateProposalCreation({
-        plugin: process,
+        enabled: process.interfaceType !== PluginInterfaceType.SAFE,


can GOVERNANCE_BUILD_CREATE_PROPOSAL_DATA slot be implemented for Safe so we don't have this branching logic?

milosh86 · 2026-10-02T13:49:19Z

    useEffect(() => {
-        checkWalletConnected();
-    }, [checkWalletConnected]);
+        if (enabled || checkWalletConnection) {


isn't checkWalletConnection always non-null?

milosh86 · 2026-10-05T12:06:17Z

     */
    fullExecuteOnly?: boolean;
+    /** Include native Safe accounts in proposal creation only. */
+    allowNativeSafe?: boolean;


do we have a case where we don't want to show Safe process?

milosh86 · 2026-10-05T12:12:57Z

+
+    return (
+        <Page.Container>
+            <SafeDaoProposalDetails


An important question for workspaces: how much is this implementation tied to DAO? Is it easy to make a SafeProposalDetails which works for any Safe transaction?

Another question, does it make sense to port some of the safeTransaction->proposal mapping to backend so we consume a common abstraction?

thekidnamedkd · 2026-10-16T11:34:30Z

Updated the description for e13d63207. The missing-process/backend-fixture blocker has cleared, and current CI passes.

Native signing is now verified with a real owner wallet: SAFE-11 on 0x8442…c39A has 2/2 confirmations. This is a combined body/process Safe, using the native proposal page. No execution was sent; the transaction remains behind earlier nonces. Process-only discovery and Members were checked separately.

The first stored read after signing lagged the accepted confirmation. A captured-response browser replay confirmed that the existing poll updates Votes on the next 30-second cycle once the new snapshot is available. Live backend catch-up time remains unmeasured. Process-only signing and a live shared-Safe fixture remain coverage limits. This stays stacked on #1397 and needs review approval.

thekidnamedkd added 2 commits September 30, 2026 18:22

feat: Add native Safe process identity and read-only governance views

efcab7a

feat: Add native Safe proposal creation and approval

5c95a69

thekidnamedkd requested a review from a team as a code owner September 30, 2026 18:58

thekidnamedkd added this pull request to stack #1438 September 30, 2026 18:58

thekidnamedkd deployed to preview September 30, 2026 18:58 — with GitHub Actions Active

thekidnamedkd added 2 commits October 1, 2026 10:50

feat: Use stored Safe transactions for native proposals

07cf805

fix: Align native Safe proposals with existing governance flows

d82156d

thekidnamedkd changed the title ~~feat: Add native Safe governance proposals~~ feat(APP-1165): Add native Safe governance proposals Oct 2, 2026

fix: Preserve Safe simulation guards when syncing governance changes

cf20404

thekidnamedkd deployed to preview October 2, 2026 07:37 — with GitHub Actions Active

milosh86 reviewed Oct 2, 2026

View reviewed changes

milosh86 reviewed Oct 5, 2026

View reviewed changes

thekidnamedkd added 2 commits October 7, 2026 10:12

feat: add Safe process identity and native execution flow

af0bbec

feat: integrate Safe process flow with canonical body identity

399c484

thekidnamedkd deployed to preview October 7, 2026 08:24 — with GitHub Actions Active

fix: name Safe bodies by address and exclude plugin updates

bed1995

thekidnamedkd deployed to preview October 7, 2026 11:46 — with GitHub Actions Active

Merge verified Safe body base into native Safe processes

0fc9443

thekidnamedkd deployed to preview October 15, 2026 08:47 — with GitHub Actions Active

thekidnamedkd added 2 commits October 15, 2026 19:16

fix: include execute-only Safes in member navigation

0fd5edf

Merge branch 'safe-biz-logic' into app-1165-safe-process-identity

2623805

thekidnamedkd deployed to preview October 15, 2026 17:18 — with GitHub Actions Active

Merge Safe indexing handoff fix into process identity

e13d632

thekidnamedkd deployed to preview October 15, 2026 21:21 — with GitHub Actions Active

thekidnamedkd mentioned this pull request Oct 16, 2026

feat(APP-1099): Implement Safe-backed SPP proposal bodies #1397

Open

11 of 16 tasks

thekidnamedkd requested review from Fabricevladimir and milosh86 October 16, 2026 11:57

Navigation Menu

Repository navigation

feat(APP-1165): Add native Safe governance proposals - #1437

feat(APP-1165): Add native Safe governance proposals#1437
thekidnamedkd wants to merge 12 commits into
safe-biz-logicfrom
app-1165-safe-process-identity

thekidnamedkd commented Sep 30, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

milosh86 left a comment

Uh oh!

milosh86 Oct 2, 2026

Uh oh!

milosh86 Oct 5, 2026

Uh oh!

milosh86 Oct 2, 2026

Uh oh!

milosh86 Oct 2, 2026

Uh oh!

milosh86 Oct 5, 2026

Uh oh!

milosh86 Oct 5, 2026

Uh oh!

thekidnamedkd commented Oct 16, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thekidnamedkd commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Verification updated 2026-10-16

Type of Change

Developer Checklist:

Review Checklist:

Uh oh!

linear-code Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milosh86 left a comment

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

milosh86 Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

thekidnamedkd commented Oct 16, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thekidnamedkd commented Sep 30, 2026 •

edited

Loading

github-actions Bot commented Sep 30, 2026 •

edited

Loading

github-actions Bot commented Sep 30, 2026 •

edited

Loading