Skip to content

ACM requires a positive serial #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UserNotFound merged 2 commits into from
Jul 15, 2026
Merged

ACM requires a positive serial #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38d9f8a
ACM requires a positive serial
UserNotFound Jul 15, 2026
2473997
lint
UserNotFound Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/mini_ca/certificate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ def initialize(
@counter = 0

x509.version = 0x2
x509.serial = serial || 0
# https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.2
# must be unique positive integer
x509.serial = serial || OpenSSL::BN.rand(128, 0)

x509.public_key = public_key

Expand Down
2 changes: 1 addition & 1 deletion lib/mini_ca/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module MiniCa
VERSION = '1.2.1'.freeze
VERSION = '1.2.2'.freeze
end
Loading