Repository navigation
docs(flutter,android): keep the push subscription open in README samples - #2099
Merged
Merged
Conversation
🟢 Tier S · Ready to merge
The Flutter and Android Push README samples now keep the returned subscription instead of immediately unsubscribing. Each README also explains when to unsubscribe as part of ending message handling.
📂 Walkthrough · 2
Reviewed |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Flutter and Android README Push samples call
subscription.unsubscribe()right after subscribing, so copying them tears the subscription down before any message can arrive. The samples now keep the subscription, and a sentence says to unsubscribe when you stop listening (dispose()/onDestroy()).Raised by Hansi on the README-only SDK PR appwrite/sdk-for-flutter#342.
Test Plan
php example.php flutter clientandphp example.php android client, then read the Push section of each generated READMEunsubscribe()exists on the generated Flutter and Android push subscriptionscomposer lint-twig,composer refactor:check,./.github/scripts/max-line-length.sh . 1200 "*.twig"Related PRs and Issues
Closes #2101