Repository navigation
chore: remove the Deno SDK target - #2079
Merged
Merged
Conversation
sdk-for-deno has not been generated or published since 2025-09-15, its README marks it deprecated in favour of npm:node-appwrite, and appwrite/appwrite no longer lists it. Keeping the language class, templates and e2e tests around only costs maintenance on every shared JS change.
🟢 Tier S · Ready to merge
This change removes the Deno SDK generator target, including its language class, templates, and end-to-end tests. It also removes Deno from the generation-suite language tables and updates the JS inheritance guide to list only Web as a child.
📂 Walkthrough · 4
Reviewed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the Deno SDK target from the generator:
src/SDK/Language/Deno.php,templates/deno/, theDeno1193/Deno1303e2e tests andtests/e2e/languages/deno, the Deno rows in the Generation suite tables, and theJS → Denoentry in the AGENTS.md inheritance table.sdk-for-deno was last pushed on 2025-09-15, its README marks it deprecated and points users to
npm:node-appwrite, and it is absent fromapp/config/sdks.phpin appwrite/appwrite and fromexample.phphere. The Deno e2e tests were already out of the CI matrix. No other language read fromtemplates/deno/.Remaining
denomentions are intentional: the Node README and TypeScript skill describe usingnode-appwritefrom Deno via npm, and the CLI supports the Deno function runtime anddeno.jsonprojects.Test Plan
tests/resources/spec-openapi3.jsononorigin/mainand on this branch;diff -rof the two trees is empty.vendor/bin/phpunit --testsuite Generation: 106 tests pass (4 skips are the existing "declares no enums" cases).composer lint,composer lint-twig,composer refactor:checkand the 1200-char Twig line check pass.Related PRs and Issues
None.
Closes #2085