Skip to content

chore: remove the Deno SDK target - #2079

Merged
ChiragAgg5k merged 1 commit into
mainfrom
chore/remove-deno
Oct 17, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
chore/remove-deno

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Removes the Deno SDK target from the generator: src/SDK/Language/Deno.php, templates/deno/, the Deno1193/Deno1303 e2e tests and tests/e2e/languages/deno, the Deno rows in the Generation suite tables, and the JS → Deno entry in the AGENTS.md inheritance table.

sdk-for-deno was last pushed on 2025-09-15, its README marks it deprecated and points users to npm:node-appwrite, and it is absent from app/config/sdks.php in appwrite/appwrite and from example.php here. The Deno e2e tests were already out of the CI matrix. No other language read from templates/deno/.

Remaining deno mentions are intentional: the Node README and TypeScript skill describe using node-appwrite from Deno via npm, and the CLI supports the Deno function runtime and deno.json projects.

Test Plan

  • Generated web (client), node (server) and react-native (client) from tests/resources/spec-openapi3.json on origin/main and on this branch; diff -r of the two trees is empty.
  • vendor/bin/phpunit --testsuite Generation: 106 tests pass (4 skips are the existing "declares no enums" cases).
  • composer lint, composer lint-twig, composer refactor:check and the 1200-char Twig line check pass.

Related PRs and Issues

None.

Closes #2085

sdk-for-deno has not been generated or published since 2025-09-15, its README marks it deprecated in favour of npm:node-appwrite, and appwrite/appwrite no longer lists it. Keeping the language class, templates and e2e tests around only costs maintenance on every shared JS change.
@hansi-codes

hansi-codes Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The removed target has no remaining generator or test references; remaining Deno support is separate CLI runtime and npm usage documentation.

This change removes the Deno SDK generator target, including its language class, templates, and end-to-end tests. It also removes Deno from the generation-suite language tables and updates the JS inheritance guide to list only Web as a child.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 4
File Change
src/SDK/Language/Deno.php, templates/deno/** Delete the Deno language implementation and its generator templates.
tests/e2e/Deno1193Test.php, tests/e2e/Deno1303Test.php, tests/e2e/languages/deno/** Remove the Deno end-to-end test cases and test script.
tests/generation/GenerationTest.php Remove Deno from the enum expectations, language class map, and shared TypeScript generation checks.
AGENTS.md Update the JS inheritance table to list Web as its only child.

Reviewed 1f231b3 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k ChiragAgg5k mentioned this pull request Oct 17, 2026
2 tasks
@ChiragAgg5k ChiragAgg5k self-assigned this Oct 17, 2026
@ChiragAgg5k
ChiragAgg5k merged commit 265167f into main Oct 17, 2026
61 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the chore/remove-deno branch October 17, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the Deno SDK target

1 participant