Repository navigation
docs(query): document the join alias default and population stddev - #2074
Merged
Merged
Conversation
The server now names an alias-less join after its table ID, so every SDK's alias-less join forms (column form, ON-list form, crossJoin) are first-class rather than rejected. The join docblocks say so, and each SDK's query tests pin that those forms send no alias and leave the default to the server. stddev and variance map to STDDEV_POP and VAR_POP on every engine, so their docblocks now say population instead of leaving it ambiguous. The deno templates are left alone: deno is no longer a generator target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🟢 Tier S · Ready to mergeThis pull request updates generated query documentation to describe alias-less joins and identify Latest changes: The newest commits clarify that an alias-less join defaults to the table ID only when that ID is a valid alias, and that the server rejects it otherwise.
📂 Walkthrough · 13
Reviewed the commits since |
A table ID that is not a valid alias is rejected rather than defaulted, so the docs no longer read as an unconditional default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
stddevandvariance: documented as population statistics. The database library maps them toSTDDEV_POPandVAR_POPon every engine.Why
Join alias is required. The database library now defaults the alias to the joined table ID when that ID is a valid alias, and otherwise returns a 400 naming the reason. (Server work is in utopia-php/query, utopia-php/database and appwrite/appwrite.)Verification
Each SDK was generated from server-ce
mainspecs and its query tests run locally:swift test; CI only builds swift)Before/after: these tests also pass on
main, because the SDKs never had the bug. The fail-before proof is at the server layer: the database library's unit and e2e tests, plus the appwrite API E2E. The new SDK tests pin the wire contract that the server default relies on.🤖 Generated with Claude Code