Repository navigation
chore(deps): update swift sdk template dependencies - #1916
renovate-appwrite[bot] wants to merge 1 commit into
Conversation
|
007e330 to
c3787ab
Compare
c3787ab to
cb3fb94
Compare
🟡 Tier B · Needs changes before merging
The Swift and Apple package templates bump async-http-client and swift-nio minimum versions. Both templates also widen the swift-distributed-tracing version range.
Fix with agent prompt### Issue 1
templates/swift/Package.swift.twig:27
**Keep distributed tracing below 1.6.0**
This range now admits 1.6.0, even though the adjacent comment and the preceding fix commit say that release makes `ServiceContext` ambiguous in async-http-client. Since the generated manifest still declares Swift tools 6.1 and 1.6.0 also requires tools 6.2, resolving this range can make generated SDKs fail to resolve or compile; the same widened range is in `templates/apple/Package.swift.twig:27`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 2
⏳ Still open from earlier reviews · 1
Reviewed |
61d77c6 to
76f5210
Compare
| // swift-distributed-tracing 1.6.0 makes ServiceContext ambiguous inside async-http-client. | ||
| .package(url: "https://github.com/apple/swift-distributed-tracing.git", "1.0.0"..<"1.6.0"), | ||
| .package(url: "https://github.com/apple/swift-nio.git", from: "2.102.0"), | ||
| .package(url: "https://github.com/apple/swift-distributed-tracing.git", "1.0.0"..<"1.7.0"), |
There was a problem hiding this comment.
Keep distributed tracing below 1.6.0
This range now admits 1.6.0, even though the adjacent comment and the preceding fix commit say that release makes ServiceContext ambiguous in async-http-client. Since the generated manifest still declares Swift tools 6.1 and 1.6.0 also requires tools 6.2, resolving this range can make generated SDKs fail to resolve or compile; the same widened range is in templates/apple/Package.swift.twig:27.
Prompt To Fix With AI
This is a comment left during a code review.
Path: templates/swift/Package.swift.twig
Line: 27
Comment:
**Keep distributed tracing below 1.6.0**
This range now admits 1.6.0, even though the adjacent comment and the preceding fix commit say that release makes `ServiceContext` ambiguous in async-http-client. Since the generated manifest still declares Swift tools 6.1 and 1.6.0 also requires tools 6.2, resolving this range can make generated SDKs fail to resolve or compile; the same widened range is in `templates/apple/Package.swift.twig:27`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟠 Major · bug · Reply if this doesn't apply.
76f5210 to
9cfdedd
Compare
This PR contains the following updates:
"1.0.0"..<"1.6.0"→"1.0.0"..<"1.7.1"2.102.0→2.104.0from: "2.102.0"→from: "2.104.0"1.36.1→1.36.2from: "1.36.1"→from: "1.36.2"Release Notes
apple/swift-distributed-tracing (apple/swift-distributed-tracing)
v1.7.1Compare Source
What's Changed
SemVer Patch
ServiceContexttypealias by @kukushechkin in #253Full Changelog: apple/swift-distributed-tracing@1.7.0...1.7.1
v1.7.0Compare Source
What's Changed
SemVer Minor
ServiceContextModuleto Swift Distributed Tracing by @kukushechkin in #252Full Changelog: apple/swift-distributed-tracing@1.6.0...1.7.0
v1.6.0Compare Source
What's Changed
SemVer Minor
Other Changes
macos_runner_poolby @kukushechkin in #249New Contributors
Full Changelog: apple/swift-distributed-tracing@1.5.0...1.6.0
v1.5.0Compare Source
What's Changed
SemVer Minor
SemVer Patch
Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.4.1...1.5.0
v1.4.1Compare Source
What's Changed
SemVer Patch
Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.4.0...1.4.1
v1.4.0Compare Source
What's Changed
SemVer Minor
SemVer Patch
withSpanset span status to.errorif operation closure throws by @daniel-grumberg in #201Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.3.1...1.4.0
v1.3.1Compare Source
What's Changed
SemVer Patch
Other Changes
Full Changelog: apple/swift-distributed-tracing@1.3.0...1.3.1
v1.3.0Compare Source
What's Changed
SemVer Minor
InMemoryTracer(in newInMemoryTracingmodule) #183 by @slashmo and @ktosoFull Changelog: apple/swift-distributed-tracing@1.2.2...1.3.0
v1.2.2Compare Source
What's Changed
SemVer Patch
SpanAttributeConvertibleconformances forInt32by @FranzBusch in #181Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.2.1...1.2.2
v1.2.1Compare Source
What's Changed
SemVer Patch
Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.2.0...1.2.1
v1.2.0Compare Source
What's Changed
SemVer Minor
activeSpanmethod toTracerProtocolby @slashmo in #160Full Changelog: apple/swift-distributed-tracing@1.1.3...1.2.0
v1.1.3Compare Source
What's Changed
SemVer Patch
Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.1.2...1.1.3
v1.1.2Compare Source
What's Changed
Updates in Swift 6 compatibility
Other Changes
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.1.1...1.1.2
v1.1.1Compare Source
What's Changed
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.1.0...1.1.1
v1.1.0Compare Source
Supported Swift versions
This release drops the support for Swift 5.6, and keeps support for 5.7, 5.8, 5.9, 5.10.
The legacy type
LegacyTracerremains available however is now deprecated.Please avoid using the deprecated "AnySpan" based APIs.
This release also cleans up some Sendability warnings in preparation for "complete concurrency checking" that will arrive in Swift 6.
What's Changed
atargument in two instances of withSpan by @ktoso in #139New Contributors
Full Changelog: apple/swift-distributed-tracing@1.0.1...1.1.0
v1.0.1Compare Source
1.0.1
Patch release adjusting how we deal with availability annotations.
Marking availability on specific types and not on package level makes it possible to adopt entirely optionally in packages which otherwise do not require the most recent (5.6+) Swift versions.
Thank you to @adam-fowler for the patch and upcoming adoption in Hummingbird.
What's Changed
New Contributors
Full Changelog: apple/swift-distributed-tracing@1.0.0...1.0.1
apple/swift-nio (apple/swift-nio)
v2.104.0Compare Source
What's Changed
SemVer Minor
ByteToMessageDecoders and typed throws by @fabianfett in #3731Other Changes
New Contributors
Full Changelog: apple/swift-nio@2.103.0...2.104.0
v2.103.0Compare Source
What's Changed
SemVer Minor
SemVer Patch
QUICBinaryEncodingStrategy.bytesNeededForIntegeras@inlinableby @fabianfett in #3718@exclusivity(unchecked)by @fabianfett in #3734Other Changes
SingleStepByteToMessageDecoderTestto Swift Testing by @fabianfett in #3729ByteToMessageDecoderVerifierTestto Swift Testing by @fabianfett in #3730New Contributors
Full Changelog: apple/swift-nio@2.102.0...2.103.0
swift-server/async-http-client (swift-server/async-http-client)
v1.36.2Compare Source
What's Changed
SemVer Patch
HTTP1Connectionreuse crash after request outlives response by @fabianfett in #929Full Changelog: swift-server/async-http-client@1.36.1...1.36.2
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.