Skip to content

feat: Rust SDK update for version 0.17.0 - #33

Closed
ChiragAgg5k wants to merge 2 commits into
mainfrom
dev
Closed

ChiragAgg5k wants to merge 2 commits into
mainfrom
dev

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the Rust SDK for version 0.17.0.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The only issue found is a minor compile failure in a new documentation example; the SDK implementation otherwise appears consistent.

Updates the Rust SDK to version 0.17.0 for Appwrite API 2.4, adding services and models for domains, WAF, passkeys, and related API changes. It also refreshes the changelog, README, and usage examples for the updated service signatures and new endpoints.

470 of 581 changed files were too large to include in full.

Verdict New comments Fixed Still open
💬 Commented 1 0 0

Note

Part of the diff was too large to review, so Hansi did not approve.

Finding Where
🟡 Give the domains vector a concrete element type docs/examples/domains/list-prices.md:15
Fix with agent prompt
### Issue 1
docs/examples/domains/list-prices.md:15
**Give the domains vector a concrete element type**

`list_prices` accepts an `impl IntoIterator<Item = impl Into<String>>`, so the empty vector leaves its element type unconstrained and this example fails to compile. Use a sample domain or explicitly type the vector.

```suggestion
        vec!["example.com"],
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 5
File Change
Cargo.toml, README.md, CHANGELOG.md, src/lib.rs, src/client.rs Bumps the SDK/API versions and updates release notes and SDK metadata.
src/services/** Updates service methods and adds the Domains and WAF services, along with new account, messaging, OAuth2, and project operations.
src/models/**, src/enums/** Adds and updates generated API response models and enums, including domain, WAF, passkey, and policy types.
docs/examples/** Adds examples for new endpoints and updates existing examples for changed method signatures.
tests/tests.rs Updates the SDK test harness for the new release.

Reviewed cea8e87 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

let domains = Domains::new(&client);

let result = domains.list_prices(
vec![],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give the domains vector a concrete element type

list_prices accepts an impl IntoIterator<Item = impl Into<String>>, so the empty vector leaves its element type unconstrained and this example fails to compile. Use a sample domain or explicitly type the vector.

Suggested change
vec![],
vec!["example.com"],
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/domains/list-prices.md
Line: 15

Comment:
**Give the domains vector a concrete element type**

`list_prices` accepts an `impl IntoIterator<Item = impl Into<String>>`, so the empty vector leaves its element type unconstrained and this example fails to compile. Use a sample domain or explicitly type the vector.

```suggestion
        vec!["example.com"],
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Superseded: replaced by a passkeys-only minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant