Skip to content

fix: SDK update for version 28.3.1 - #76

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/28.3.1
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/28.3.1

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 28.3.1.

What's Changed

  • Fixed: added ProjectAuthMethodId::PASSKEY, so project.updateAuthMethod can enable passkeys
  • Fixed: added ProjectPolicyId::PASSKEY and the PolicyPasskey model, so getPolicy and listPolicies return the passkey policy

Completes the passkeys release: the previous patch shipped the passkey methods, but not the passkey auth method and policy IDs or the PolicyPasskey model, so the SDK could not enable passkeys on a project. Made the same way, from a spec with exactly these pieces removed, three-way merged onto main. Verified live: updateAuthMethod(passkey), getPolicy(passkey) and listPolicies against Appwrite Cloud.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The only issue is a minor documentation omission; the passkey support itself is wired into the enum, model, and response hydration.

This update adds the passkey auth-method and policy IDs, introduces the PolicyPasskey model, and uses it when hydrating passkey responses from get_policy. It also updates the Ruby gem and client SDK versions to 28.3.1.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Include passkey in the documented get_policy IDs lib/appwrite/services/project.rb:3760
Fix with agent prompt
### Issue 1
lib/appwrite/services/project.rb:3760
**Include passkey in the documented get_policy IDs**

The `@param` list immediately above still omits `passkey`, so the SDK docs say this newly supported policy ID is not a valid `get_policy` argument.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 9
File Change
CHANGELOG.md Adds the 28.3.1 release notes for the passkey SDK additions.
appwrite.gemspec Bumps the gem version to 28.3.1.
lib/appwrite.rb Loads the new passkey policy model.
lib/appwrite/client.rb Updates the SDK version sent by the client to 28.3.1.
lib/appwrite/enums/project_auth_method_id.rb Adds the passkey auth-method ID.
lib/appwrite/enums/project_policy_id.rb Adds the passkey policy ID.
lib/appwrite/models/policy_passkey.rb Defines the passkey policy model and its map conversion.
lib/appwrite/models/project_auth_method.rb Allows passkey as a valid project auth-method ID.
lib/appwrite/services/project.rb Hydrates passkey policy responses from get_policy as PolicyPasskey.

Reviewed 4a94e9c · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

# @param [ProjectPolicyId] policy_id Policy ID. Can be one of: password-dictionary, password-history, password-strength, password-personal-data, session-alert, session-duration, session-invalidation, session-limit, user-limit, membership-privacy, mfa-factors, deny-aliased-email, deny-disposable-email, deny-free-email, deny-corporate-email.
#
# @return [PolicyPasswordDictionary, PolicyPasswordHistory, PolicyPasswordStrength, PolicyPasswordPersonalData, PolicySessionAlert, PolicySessionDuration, PolicySessionInvalidation, PolicySessionLimit, PolicyUserLimit, PolicyMembershipPrivacy, PolicyMfaFactors, PolicyDenyAliasedEmail, PolicyDenyDisposableEmail, PolicyDenyFreeEmail, PolicyDenyCorporateEmail]
# @return [PolicyPasswordDictionary, PolicyPasswordHistory, PolicyPasswordStrength, PolicyPasswordPersonalData, PolicySessionAlert, PolicySessionDuration, PolicySessionInvalidation, PolicySessionLimit, PolicyUserLimit, PolicyMembershipPrivacy, PolicyMfaFactors, PolicyDenyAliasedEmail, PolicyDenyDisposableEmail, PolicyDenyFreeEmail, PolicyDenyCorporateEmail, PolicyPasskey]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include passkey in the documented get_policy IDs

The @param list immediately above still omits passkey, so the SDK docs say this newly supported policy ID is not a valid get_policy argument.

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/appwrite/services/project.rb
Line: 3760

Comment:
**Include passkey in the documented get_policy IDs**

The `@param` list immediately above still omits `passkey`, so the SDK docs say this newly supported policy ID is not a valid `get_policy` argument.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit f202ae9 into main Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant