Skip to content

feat: SDK update for version 1.2.0 - #123

Merged
ChiragAgg5k merged 1 commit into
1.xfrom
release/1.2.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
1.xfrom
release/1.2.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 1.2.0.

What's Changed

  • Added: account passkey methods listPasskeys, createPasskey, getPasskey, updatePasskey, deletePasskey and updatePasskeyVerification
  • Added: account.createPasskeyToken and account.updatePasskeyToken for passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto 1.1.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The only issue is a minor documentation example that submits an empty credential instead of the required authenticator response.

This release adds passkey registration, management, and sign-in methods to the Account service, along with passkey-related models. It also updates the SDK version and adds example snippets for the new methods.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Example sends an empty passkey credential docs/examples/account/update-passkey-token.md:12
Fix with agent prompt
### Issue 1
docs/examples/account/update-passkey-token.md:12
**Example sends an empty passkey credential**

The endpoint requires the JSON credential returned by the authenticator, but this example passes `{}`, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 5
File Change
CHANGELOG.md, package.json, package-lock.json Document the 1.2.0 release and bump package metadata.
src/client.ts Update the SDK version sent with requests.
src/models.ts Add passkey, challenge, passkey-list, and token-secret models.
src/services/account.ts Add account methods for passkey registration, management, verification, and sign-in.
docs/examples/account/*passkey*.md Add usage snippets for the new passkey methods.

Reviewed 3d4985b · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary


const result = await account.updatePasskeyToken({
challengeId: '<CHALLENGE_ID>',
credential: {},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example sends an empty passkey credential

The endpoint requires the JSON credential returned by the authenticator, but this example passes {}, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 12

Comment:
**Example sends an empty passkey credential**

The endpoint requires the JSON credential returned by the authenticator, but this example passes `{}`, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 8f716ce into 1.x Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant