Repository navigation
feat: SDK update for version 1.2.0 - #123
Conversation
🔵 Tier A · Mergeable after minor fixes
This release adds passkey registration, management, and sign-in methods to the Account service, along with passkey-related models. It also updates the SDK version and adds example snippets for the new methods.
Fix with agent prompt### Issue 1
docs/examples/account/update-passkey-token.md:12
**Example sends an empty passkey credential**
The endpoint requires the JSON credential returned by the authenticator, but this example passes `{}`, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 5
Reviewed |
|
|
||
| const result = await account.updatePasskeyToken({ | ||
| challengeId: '<CHALLENGE_ID>', | ||
| credential: {}, |
There was a problem hiding this comment.
Example sends an empty passkey credential
The endpoint requires the JSON credential returned by the authenticator, but this example passes {}, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 12
Comment:
**Example sends an empty passkey credential**
The endpoint requires the JSON credential returned by the authenticator, but this example passes `{}`, so copying it always results in a rejected sign-in request. The registration verification example has the same empty-credential placeholder.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
This PR contains updates to the SDK for version 1.2.0.
What's Changed
accountpasskey methodslistPasskeys,createPasskey,getPasskey,updatePasskey,deletePasskeyandupdatePasskeyVerificationaccount.createPasskeyTokenandaccount.updatePasskeyTokenfor passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
1.1.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.