Repository navigation
fix: SDK update for version 30.3.1 - #93
Conversation
🔵 Tier A · Mergeable after minor fixes
Adds passkey auth-method and policy identifiers plus a
Fix with agent prompt### Issue 1
tests/Appwrite/Services/ProjectTest.php:3230
**Test does not exercise the new passkey policy ID**
The mocked response has `$id = passkey`, but this test still calls `ProjectPolicyId::PASSWORDDICTIONARY()` and does not assert the request path, so it passes even if `PASSKEY()` is missing or `getPolicy(PASSKEY())` targets the wrong endpoint. It also replaces the prior deny-corporate-email hydration case; please exercise the passkey ID/path and retain coverage for that existing branch.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 7
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
| ); | ||
|
|
||
| $this->assertInstanceOf(\Appwrite\Models\PolicyDenyCorporateEmail::class, $response); | ||
| $this->assertInstanceOf(\Appwrite\Models\PolicyPasskey::class, $response); |
There was a problem hiding this comment.
Test does not exercise the new passkey policy ID
The mocked response has $id = passkey, but this test still calls ProjectPolicyId::PASSWORDDICTIONARY() and does not assert the request path, so it passes even if PASSKEY() is missing or getPolicy(PASSKEY()) targets the wrong endpoint. It also replaces the prior deny-corporate-email hydration case; please exercise the passkey ID/path and retain coverage for that existing branch.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/Appwrite/Services/ProjectTest.php
Line: 3230
Comment:
**Test does not exercise the new passkey policy ID**
The mocked response has `$id = passkey`, but this test still calls `ProjectPolicyId::PASSWORDDICTIONARY()` and does not assert the request path, so it passes even if `PASSKEY()` is missing or `getPolicy(PASSKEY())` targets the wrong endpoint. It also replaces the prior deny-corporate-email hydration case; please exercise the passkey ID/path and retain coverage for that existing branch.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
1 participant
This PR contains updates to the SDK for version 30.3.1.
What's Changed
ProjectAuthMethodId::PASSKEY(), soproject.updateAuthMethodcan enable passkeysProjectPolicyId::PASSKEY()and thePolicyPasskeymodel, sogetPolicyandlistPoliciesreturn the passkey policyCompletes the passkeys release: the previous patch shipped the passkey methods, but not the
passkeyauth method and policy IDs or thePolicyPasskeymodel, so the SDK could not enable passkeys on a project. Made the same way, from a spec with exactly these pieces removed, three-way merged ontomain. Verified live:updateAuthMethod(passkey),getPolicy(passkey)andlistPoliciesagainst Appwrite Cloud.