Repository navigation
feat: SDK update for version 30.3.0 - #92
Merged
Merged
Conversation
🔵 Tier A · Mergeable after minor fixes
Adds PHP SDK support for passkey registration and sign-in, passkey management for accounts and users, and project passkey policy configuration. It also adds the associated response models, documentation, examples, and service tests for version 30.3.0.
Fix with agent prompt### Issue 1
tests/Appwrite/Services/AccountTest.php:763-764
**Assert the passkey request contract**
This stub accepts any `Client::call` arguments and only returns fixture data, so this test still passes if the method uses the wrong HTTP method or path, or sends incorrect parameters. The other new passkey method tests use the same pattern, leaving their request contracts unverified too.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 6
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
Comment on lines
+763
to
+764
| ->allows()->call(Mockery::any(), Mockery::any(), Mockery::any(), Mockery::any()) | ||
| ->andReturn($data); |
There was a problem hiding this comment.
Assert the passkey request contract
This stub accepts any Client::call arguments and only returns fixture data, so this test still passes if the method uses the wrong HTTP method or path, or sends incorrect parameters. The other new passkey method tests use the same pattern, leaving their request contracts unverified too.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/Appwrite/Services/AccountTest.php
Line: 763-764
Comment:
**Assert the passkey request contract**
This stub accepts any `Client::call` arguments and only returns fixture data, so this test still passes if the method uses the wrong HTTP method or path, or sends incorrect parameters. The other new passkey method tests use the same pattern, leaving their request contracts unverified too.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the SDK for version 30.3.0.
What's Changed
accountpasskey methodslistPasskeys,createPasskey,getPasskey,updatePasskey,deletePasskeyandupdatePasskeyVerificationaccount.createPasskeyTokenandaccount.updatePasskeyTokenfor passkey sign-inusers.listPasskeys,users.getPasskey,users.updatePasskeyandusers.deletePasskeyproject.updatePasskeyPolicyto configure passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
main: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.