Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## 29.3.1

* Fixed: added `ProjectAuthMethodId.Passkey`, so `project.updateAuthMethod` can enable passkeys
* Fixed: added `ProjectPolicyId.Passkey` and the `Models.PolicyPasskey` model, so `getPolicy` and `listPolicies` return the passkey policy

## 29.3.0

* Added: `account` passkey methods `listPasskeys`, `createPasskey`, `getPasskey`, `updatePasskey`, `deletePasskey` and `updatePasskeyVerification`
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "node-appwrite",
"homepage": "https://appwrite.io/support",
"description": "Appwrite is an open-source self-hosted backend server that abstracts and simplifies complex and repetitive development tasks behind a very simple REST API",
"version": "29.3.0",
"version": "29.3.1",
"license": "BSD-3-Clause",
"main": "dist/index.js",
"type": "commonjs",
Expand Down
4 changes: 2 additions & 2 deletions src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class AppwriteException extends Error {
}

function getUserAgent() {
let ua = 'AppwriteNodeJSSDK/29.3.0';
let ua = 'AppwriteNodeJSSDK/29.3.1';

// `process` is a global in Node.js, but not fully available in all runtimes.
const platform: string[] = [];
Expand Down Expand Up @@ -142,7 +142,7 @@ class Client {
'x-sdk-name': 'Node.js',
'x-sdk-platform': 'server',
'x-sdk-language': 'nodejs',
'x-sdk-version': '29.3.0',
'x-sdk-version': '29.3.1',
'user-agent': getUserAgent(),
'X-Appwrite-Response-Format': '2.0.0',
};
Expand Down
1 change: 1 addition & 0 deletions src/enums/project-auth-method-id.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ export enum ProjectAuthMethodId {
Invites = 'invites',
Jwt = 'jwt',
Phone = 'phone',
Passkey = 'passkey',
}
1 change: 1 addition & 0 deletions src/enums/project-policy-id.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ export enum ProjectPolicyId {
Denydisposableemail = 'deny-disposable-email',
Denyfreeemail = 'deny-free-email',
Denycorporateemail = 'deny-corporate-email',
Passkey = 'passkey',
}
19 changes: 19 additions & 0 deletions src/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ export namespace Models {
| Models.PolicyDenyDisposableEmail
| Models.PolicyDenyFreeEmail
| Models.PolicyDenyCorporateEmail
| Models.PolicyPasskey
)[];
};

Expand Down Expand Up @@ -6266,6 +6267,24 @@ export namespace Models {
custom: boolean;
};

/**
* Policy Passkey
*/
export type PolicyPasskey = {
/**
* Policy ID.
*/
$id: string;
/**
* Relying party ID passkeys are bound to. Empty until configured.
*/
rpId: string;
/**
* Web origins passkeys work on, from the project's platforms on the relying party ID and a localhost web platform. Read-only.
*/
origins: string[];
};

/**
* Platform Web
*/
Expand Down
7 changes: 5 additions & 2 deletions src/services/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7877,7 +7877,7 @@ export class Project {
*
* @param {ProjectPolicyId} params.policyId - Policy ID. Can be one of: password-dictionary, password-history, password-strength, password-personal-data, session-alert, session-duration, session-invalidation, session-limit, user-limit, membership-privacy, mfa-factors, deny-aliased-email, deny-disposable-email, deny-free-email, deny-corporate-email.
* @throws {AppwriteException}
* @returns {Promise<Models.PolicyPasswordDictionary | Models.PolicyPasswordHistory | Models.PolicyPasswordStrength | Models.PolicyPasswordPersonalData | Models.PolicySessionAlert | Models.PolicySessionDuration | Models.PolicySessionInvalidation | Models.PolicySessionLimit | Models.PolicyUserLimit | Models.PolicyMembershipPrivacy | Models.PolicyMfaFactors | Models.PolicyDenyAliasedEmail | Models.PolicyDenyDisposableEmail | Models.PolicyDenyFreeEmail | Models.PolicyDenyCorporateEmail>}
* @returns {Promise<Models.PolicyPasswordDictionary | Models.PolicyPasswordHistory | Models.PolicyPasswordStrength | Models.PolicyPasswordPersonalData | Models.PolicySessionAlert | Models.PolicySessionDuration | Models.PolicySessionInvalidation | Models.PolicySessionLimit | Models.PolicyUserLimit | Models.PolicyMembershipPrivacy | Models.PolicyMfaFactors | Models.PolicyDenyAliasedEmail | Models.PolicyDenyDisposableEmail | Models.PolicyDenyFreeEmail | Models.PolicyDenyCorporateEmail | Models.PolicyPasskey>}
*/
getPolicy(params: {
policyId: ProjectPolicyId;
Expand All @@ -7897,13 +7897,14 @@ export class Project {
| Models.PolicyDenyDisposableEmail
| Models.PolicyDenyFreeEmail
| Models.PolicyDenyCorporateEmail
| Models.PolicyPasskey
>;
/**
* Get a policy by its unique ID. This endpoint returns the current configuration for the requested project policy.
*
* @param {ProjectPolicyId} policyId - Policy ID. Can be one of: password-dictionary, password-history, password-strength, password-personal-data, session-alert, session-duration, session-invalidation, session-limit, user-limit, membership-privacy, mfa-factors, deny-aliased-email, deny-disposable-email, deny-free-email, deny-corporate-email.
* @throws {AppwriteException}
* @returns {Promise<Models.PolicyPasswordDictionary | Models.PolicyPasswordHistory | Models.PolicyPasswordStrength | Models.PolicyPasswordPersonalData | Models.PolicySessionAlert | Models.PolicySessionDuration | Models.PolicySessionInvalidation | Models.PolicySessionLimit | Models.PolicyUserLimit | Models.PolicyMembershipPrivacy | Models.PolicyMfaFactors | Models.PolicyDenyAliasedEmail | Models.PolicyDenyDisposableEmail | Models.PolicyDenyFreeEmail | Models.PolicyDenyCorporateEmail>}
* @returns {Promise<Models.PolicyPasswordDictionary | Models.PolicyPasswordHistory | Models.PolicyPasswordStrength | Models.PolicyPasswordPersonalData | Models.PolicySessionAlert | Models.PolicySessionDuration | Models.PolicySessionInvalidation | Models.PolicySessionLimit | Models.PolicyUserLimit | Models.PolicyMembershipPrivacy | Models.PolicyMfaFactors | Models.PolicyDenyAliasedEmail | Models.PolicyDenyDisposableEmail | Models.PolicyDenyFreeEmail | Models.PolicyDenyCorporateEmail | Models.PolicyPasskey>}
* @deprecated Use the object parameter style method for a better developer experience.
*/
getPolicy(
Expand All @@ -7924,6 +7925,7 @@ export class Project {
| Models.PolicyDenyDisposableEmail
| Models.PolicyDenyFreeEmail
| Models.PolicyDenyCorporateEmail
| Models.PolicyPasskey
>;
getPolicy(
paramsOrFirst: { policyId: ProjectPolicyId } | ProjectPolicyId,
Expand All @@ -7943,6 +7945,7 @@ export class Project {
| Models.PolicyDenyDisposableEmail
| Models.PolicyDenyFreeEmail
| Models.PolicyDenyCorporateEmail
| Models.PolicyPasskey
> {
let params: { policyId: ProjectPolicyId };

Expand Down
3 changes: 2 additions & 1 deletion test/services/project.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1940,7 +1940,8 @@ describe('Project', () => {
test('test method getPolicy()', async () => {
const data = {
'\\$id': 'password-dictionary',
enabled: true,
rpId: 'example.com',
origins: [],
Comment on lines +1943 to +1944

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test still exercises password-dictionary, not passkey

This fixture has passkey fields, but the test still calls getPolicy('password-dictionary') and its $id remains password-dictionary. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/project.test.js
Line: 1943-1944

Comment:
**Test still exercises password-dictionary, not passkey**

This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

};
mockedFetch.mockImplementation(() => Response.json(data));
const response = await project.getPolicy('password-dictionary');
Expand Down
Loading