Repository navigation
feat: SDK update for version 29.3.0 - #174
Conversation
🔵 Tier A · Mergeable after minor fixes
This release bumps the SDK to 29.3.0 and adds passkey registration, management, and sign-in methods for accounts and users, along with project passkey-policy configuration. It also adds the passkey and token models, examples, and service tests.
Fix with agent prompt### Issue 1
test/services/account.test.js:697
**Assert the request contract in passkey service tests**
These tests only compare the mocked response, while `mockedFetch` returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 8
Reviewed |
| // Remove custom toString method on the objects to allow for clean data comparison. | ||
| delete response.toString; | ||
|
|
||
| expect(response).toEqual(data); |
There was a problem hiding this comment.
Assert the request contract in passkey service tests
These tests only compare the mocked response, while mockedFetch returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/account.test.js
Line: 697
Comment:
**Assert the request contract in passkey service tests**
These tests only compare the mocked response, while `mockedFetch` returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This PR contains updates to the SDK for version 29.3.0.
What's Changed
accountpasskey methodslistPasskeys,createPasskey,getPasskey,updatePasskey,deletePasskeyandupdatePasskeyVerificationaccount.createPasskeyTokenandaccount.updatePasskeyTokenfor passkey sign-inusers.listPasskeys,users.getPasskey,users.updatePasskeyandusers.deletePasskeyproject.updatePasskeyPolicyto configure passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
29.x: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.