Skip to content

feat: SDK update for version 29.3.0 - #174

Merged
ChiragAgg5k merged 1 commit into
29.xfrom
release-29.3.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
29.xfrom
release-29.3.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 29.3.0.

What's Changed

  • Added: account passkey methods listPasskeys, createPasskey, getPasskey, updatePasskey, deletePasskey and updatePasskeyVerification
  • Added: account.createPasskeyToken and account.updatePasskeyToken for passkey sign-in
  • Added: users.listPasskeys, users.getPasskey, users.updatePasskey and users.deletePasskey
  • Added: project.updatePasskeyPolicy to configure passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto 29.x: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The only finding is a minor test-coverage gap: the new tests do not verify the HTTP requests sent by the added APIs.

This release bumps the SDK to 29.3.0 and adds passkey registration, management, and sign-in methods for accounts and users, along with project passkey-policy configuration. It also adds the passkey and token models, examples, and service tests.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Assert the request contract in passkey service tests test/services/account.test.js:697
Fix with agent prompt
### Issue 1
test/services/account.test.js:697
**Assert the request contract in passkey service tests**

These tests only compare the mocked response, while `mockedFetch` returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 8
File Change
CHANGELOG.md, package.json, package-lock.json Records the 29.3.0 release and updates the package version.
src/client.ts Updates the SDK version in request headers and the user agent.
src/models.ts Adds token-secret, passkey, passkey-challenge, and passkey-list models.
src/services/account.ts Adds account passkey management, verification, and sign-in token methods.
src/services/users.ts Adds administrative methods to list, retrieve, rename, and delete user passkeys.
src/services/project.ts Adds the project passkey relying-party policy method.
docs/examples/account/*, docs/examples/users/*, docs/examples/project/update-passkey-policy.md Adds examples for the new passkey methods.
test/services/account.test.js, test/services/users.test.js, test/services/project.test.js Adds response-based tests for the passkey methods.

Reviewed 29a2705 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

// Remove custom toString method on the objects to allow for clean data comparison.
delete response.toString;

expect(response).toEqual(data);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert the request contract in passkey service tests

These tests only compare the mocked response, while mockedFetch returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/account.test.js
Line: 697

Comment:
**Assert the request contract in passkey service tests**

These tests only compare the mocked response, while `mockedFetch` returns it regardless of the URL, method, or payload. A regression in the new endpoint paths or HTTP verbs (including this verification call) would therefore still pass; assert the outgoing request as well.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit a958fe8 into 29.x Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant