Skip to content

feat: SDK update for version v7.11.0 - #87

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/v7.11.0
Oct 14, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/v7.11.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version v7.11.0. It is patched onto the previous release tag, so it only adds the changes below; existing method signatures keep their parameter order.

What's Changed

  • Added: project environments with Project.CreateEnvironment, GetEnvironment, ListEnvironments, UpdateEnvironment and DeleteEnvironment
  • Added: Project.UpdatePasswordRotationPolicy and the PolicyPasswordRotation model
  • Added: WithCreateMembershipMembershipId on Teams.CreateMembership, and fingerprints options on Android platform create and update
  • Added: Project.ParentId and BillingPlan.Environments

@hansi-codes

hansi-codes Bot commented Oct 14, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The implementation appears consistent, but the new endpoint tests do not verify the request paths or payloads.

This update adds project environment management and password-rotation policy APIs, along with Android signing fingerprints and a membership ID option. It also exposes the new project and billing-plan fields and updates the SDK version metadata and examples.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Endpoint tests do not verify the new request contract project/project_test.go:251
Fix with agent prompt
### Issue 1
project/project_test.go:251-259
**Endpoint tests do not verify the new request contract**

These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 15
File Change
CHANGELOG.md Documents the v7.11.0 SDK additions.
client/client.go Updates the SDK version in request headers.
docs/examples/project/create-android-platform.md Shows how to pass Android signing fingerprints when creating a platform.
docs/examples/project/*-environment.md Adds examples for creating, listing, getting, updating, and deleting environments.
docs/examples/project/update-android-platform.md Shows how to pass fingerprints when updating an Android platform.
docs/examples/project/update-password-rotation-policy.md Adds an example for updating password-rotation settings.
docs/examples/teams/create-membership.md Shows how to set a membership ID when inviting a team member.
models/billingPlan.go Adds the environment limit to billing plan responses.
models/platformAndroid.go Adds Android certificate fingerprints to platform responses.
models/policyPasswordRotation.go Adds the password-rotation policy model and default handling.
models/policyPasswordRotation_test.go Adds a JSON round-trip test for the new policy model.
models/project.go Adds the parent project ID field.
project/project.go Adds environment and password-rotation endpoints and Android fingerprint options.
project/project_test.go Adds tests for environment and password-rotation endpoint calls.
teams/teams.go Adds the optional membership ID to team membership creation.

Reviewed b41ed3a · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment thread project/project_test.go
Comment on lines +251 to +259
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method != "GET" {
t.Errorf("Expected method GET, got %s", r.Method)
}

w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(mockResponse))
}))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoint tests do not verify the new request contract

These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.

Prompt To Fix With AI
This is a comment left during a code review.
Path: project/project_test.go
Line: 251-259

Comment:
**Endpoint tests do not verify the new request contract**

These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 98b243d into main Oct 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant