Repository navigation
feat: SDK update for version v7.11.0 - #87
Conversation
🔵 Tier A · Mergeable after minor fixes
This update adds project environment management and password-rotation policy APIs, along with Android signing fingerprints and a membership ID option. It also exposes the new project and billing-plan fields and updates the SDK version metadata and examples.
Fix with agent prompt### Issue 1
project/project_test.go:251-259
**Endpoint tests do not verify the new request contract**
These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 15
Reviewed |
| ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.Method != "GET" { | ||
| t.Errorf("Expected method GET, got %s", r.Method) | ||
| } | ||
|
|
||
| w.Header().Set("Content-Type", "application/json") | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte(mockResponse)) | ||
| })) |
There was a problem hiding this comment.
Endpoint tests do not verify the new request contract
These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.
Prompt To Fix With AI
This is a comment left during a code review.
Path: project/project_test.go
Line: 251-259
Comment:
**Endpoint tests do not verify the new request contract**
These mocks accept any URL and do not inspect query or body parameters, so the tests still pass if an environment method uses the wrong route or sends the wrong fields. Checking the path and decoded request parameters in the handler would exercise the new endpoint contract.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This PR contains updates to the SDK for version v7.11.0. It is patched onto the previous release tag, so it only adds the changes below; existing method signatures keep their parameter order.
What's Changed
Project.CreateEnvironment,GetEnvironment,ListEnvironments,UpdateEnvironmentandDeleteEnvironmentProject.UpdatePasswordRotationPolicyand thePolicyPasswordRotationmodelWithCreateMembershipMembershipIdonTeams.CreateMembership, andfingerprintsoptions on Android platform create and updateProject.ParentIdandBillingPlan.Environments