Skip to content

feat: SDK update for version v7.10.0 - #86

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/v7.10.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/v7.10.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version v7.10.0.

What's Changed

  • Added: Account passkey methods ListPasskeys, CreatePasskey, GetPasskey, UpdatePasskey, DeletePasskey and UpdatePasskeyVerification
  • Added: Account.CreatePasskeyToken and Account.UpdatePasskeyToken for passkey sign-in
  • Added: Users.ListPasskeys, Users.GetPasskey, Users.UpdatePasskey and Users.DeletePasskey
  • Added: Project.UpdatePasskeyPolicy to configure passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto main: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

Limited by an open minor finding: Use an object for the credential examples

This adds passkey management, registration and sign-in flows, and project passkey-policy configuration, along with their models, tests, and examples. It also updates the SDK version metadata to v7.10.0 while keeping the response-format header unchanged.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Use an object for the credential examples docs/examples/account/update-passkey-token.md:22
Fix with agent prompt
### Issue 1
docs/examples/account/update-passkey-token.md:22
**Use an object for the credential examples**

The passkey token and verification endpoints take the credential JSON object produced by `navigator.credentials.get().toJSON()`, but `[]interface{}{}` encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 13
File Change
CHANGELOG.md Documents the v7.10.0 passkey API and model additions.
account/account.go Adds account passkey management, registration verification, and sign-in token methods.
account/account_test.go Adds request tests for the new account passkey methods.
client/client.go Updates SDK version metadata to v7.10.0.
docs/examples/account/*.md Adds examples for account passkey registration, management, and sign-in.
docs/examples/project/update-passkey-policy.md Adds an example for configuring a project's passkey policy.
docs/examples/users/*.md Adds examples for user passkey management.
models/passkey.go, models/passkeyChallenge.go, models/passkeyList.go, models/tokenSecret.go Adds the passkey and token response models.
models/passkey_test.go, models/passkeyChallenge_test.go, models/passkeyList_test.go, models/tokenSecret_test.go Adds serialization tests for the new models.
project/project.go Adds the passkey-policy update method.
project/project_test.go Adds a request test for passkey-policy updates.
users/users.go Adds administrative user passkey management methods.
users/users_test.go Adds request tests for user passkey management.
🔇 Filtered out · 1

Findings Hansi considered but did not post.

Finding Why
Return the passkey policy model Verifier: The finding conflates the GET policy response with the PATCH update response. Test UpdatePasskeyPolicy supplies a full project response (project/project_test.go:3024-3075), and the existing policy update methods likewise return models.Project while GetPolicy returns policy-specific models. No repository evidence establishes that this PATCH returns a PolicyPasskey object, so the claimed return-type bug is unsupported.

Reviewed 485b800 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary


response, err := service.UpdatePasskeyToken(
"<CHALLENGE_ID>",
[]interface{}{},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an object for the credential examples

The passkey token and verification endpoints take the credential JSON object produced by navigator.credentials.get().toJSON(), but []interface{}{} encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 22

Comment:
**Use an object for the credential examples**

The passkey token and verification endpoints take the credential JSON object produced by `navigator.credentials.get().toJSON()`, but `[]interface{}{}` encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit e2ab309 into main Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant