Repository navigation
feat: SDK update for version v7.10.0 - #86
Conversation
🔵 Tier A · Mergeable after minor fixes
This adds passkey management, registration and sign-in flows, and project passkey-policy configuration, along with their models, tests, and examples. It also updates the SDK version metadata to v7.10.0 while keeping the response-format header unchanged.
Fix with agent prompt### Issue 1
docs/examples/account/update-passkey-token.md:22
**Use an object for the credential examples**
The passkey token and verification endpoints take the credential JSON object produced by `navigator.credentials.get().toJSON()`, but `[]interface{}{}` encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 13
🔇 Filtered out · 1Findings Hansi considered but did not post.
Reviewed |
|
|
||
| response, err := service.UpdatePasskeyToken( | ||
| "<CHALLENGE_ID>", | ||
| []interface{}{}, |
There was a problem hiding this comment.
Use an object for the credential examples
The passkey token and verification endpoints take the credential JSON object produced by navigator.credentials.get().toJSON(), but []interface{}{} encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/update-passkey-token.md
Line: 22
Comment:
**Use an object for the credential examples**
The passkey token and verification endpoints take the credential JSON object produced by `navigator.credentials.get().toJSON()`, but `[]interface{}{}` encodes as an array and is rejected. The verification example uses the same array placeholder, so these examples do not demonstrate a request with the required shape.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
This PR contains updates to the SDK for version v7.10.0.
What's Changed
Accountpasskey methodsListPasskeys,CreatePasskey,GetPasskey,UpdatePasskey,DeletePasskeyandUpdatePasskeyVerificationAccount.CreatePasskeyTokenandAccount.UpdatePasskeyTokenfor passkey sign-inUsers.ListPasskeys,Users.GetPasskey,Users.UpdatePasskeyandUsers.DeletePasskeyProject.UpdatePasskeyPolicyto configure passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
main: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.