Repository navigation
feat: Go SDK update for version v7.10.0 - #85
ChiragAgg5k wants to merge 2 commits into
Conversation
🔵 Tier A · Mergeable after minor fixes
This update adds passkey APIs and models, passkey and password-rotation policies, Android certificate fingerprints, and an optional membership ID. It also adds spec-default unmarshalling to response models and bumps the Go SDK version to v7.10.0. 221 of 351 changed files were too large to include in full.
Note Part of the diff was too large to review, so Hansi did not approve.
Fix with agent prompt### Issue 1
models/account.go:77-80
**Test sparse responses against the seeded defaults**
The model tests round-trip fully populated values, but do not exercise an object with omitted fields through this new defaulting path. A missing or incorrect entry in these generated defaults would therefore go unnoticed while returning the wrong model value; please add a sparse-response assertion for the new behavior.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 5
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
| if err := json.Unmarshal([]byte("{\"$id\":\"\",\"$createdAt\":\"\",\"$updatedAt\":\"\",\"name\":\"\",\"registration\":\"\",\"status\":true,\"labels\":[],\"passwordUpdate\":\"\",\"email\":\"\",\"phone\":\"\",\"emailVerification\":false,\"phoneVerification\":false,\"mfa\":false,\"accessedAt\":\"\"}"), &fields); err != nil { | ||
| return err | ||
| } | ||
| if err := json.Unmarshal(data, &fields); err != nil { |
There was a problem hiding this comment.
Test sparse responses against the seeded defaults
The model tests round-trip fully populated values, but do not exercise an object with omitted fields through this new defaulting path. A missing or incorrect entry in these generated defaults would therefore go unnoticed while returning the wrong model value; please add a sparse-response assertion for the new behavior.
Prompt To Fix With AI
This is a comment left during a code review.
Path: models/account.go
Line: 77-80
Comment:
**Test sparse responses against the seeded defaults**
The model tests round-trip fully populated values, but do not exercise an object with omitted fields through this new defaulting path. A missing or incorrect entry in these generated defaults would therefore go unnoticed while returning the wrong model value; please add a sparse-response assertion for the new behavior.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
|
Superseded: replaced by a passkeys-only minor release. |
1 participant
This PR contains updates to the Go SDK for version v7.10.0.