Skip to content

feat: SDK update for version v7.9.0 - #84

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/v7.9.0
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/v7.9.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version v7.9.0.

What's Changed

  • Added: WithCreateInterval and WithUpdateInterval options on Functions to run a function every N minutes
  • Added: Interval on the Function model and FunctionsIntervalMinimum on the BillingPlan model

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The interval request and response behavior is untested, so merge confidence is A until that minor test gap is addressed.

This update exposes interval scheduling through function creation and updates, adds interval data to the Function and BillingPlan models, and advances the SDK version headers. The examples and changelog now include the new v7.9.0 options and model fields.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Test interval serialization and model decoding functions/functions.go:331
Fix with agent prompt
### Issue 1
functions/functions.go:331-333
**Test interval serialization and model decoding**

The existing Functions tests call Create and Update, but their handlers only check the HTTP method, so they would pass if these new options stopped sending `interval`. The new Function response field is also not covered by its model round-trip test; assertions for the request payloads and decoded interval would protect this feature.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 10
File Change
CHANGELOG.md Documents the v7.9.0 interval options and model fields.
client/client.go Updates SDK version identifiers in request headers.
docs/examples/functions/create.md Adds the create interval option to the example.
docs/examples/functions/update.md Adds the update interval option to the example.
functions/functions.go Adds interval options and request parameters for creating and updating functions.
models/billingPlan.go Adds the minimum permitted function schedule interval to BillingPlan.
models/billingPlan_test.go Includes the new billing-plan field in the model round-trip test.
models/function.go Adds the interval field to Function.
models/organization_test.go Adds the new billing-plan field to the nested organization fixture.
organization/organization_test.go Adds the new billing-plan field to organization response fixtures.

Reviewed a0e6b23 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment thread functions/functions.go
Comment on lines +331 to +333
if options.enabledSetters["Interval"] {
params["interval"] = options.Interval
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test interval serialization and model decoding

The existing Functions tests call Create and Update, but their handlers only check the HTTP method, so they would pass if these new options stopped sending interval. The new Function response field is also not covered by its model round-trip test; assertions for the request payloads and decoded interval would protect this feature.

Prompt To Fix With AI
This is a comment left during a code review.
Path: functions/functions.go
Line: 331-333

Comment:
**Test interval serialization and model decoding**

The existing Functions tests call Create and Update, but their handlers only check the HTTP method, so they would pass if these new options stopped sending `interval`. The new Function response field is also not covered by its model round-trip test; assertions for the request payloads and decoded interval would protect this feature.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit e223d53 into main Oct 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the release/v7.9.0 branch October 9, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant