Skip to content

feat: SDK update for version 8.3.0 - #108

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/8.3.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/8.3.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 8.3.0.

What's Changed

  • Added: account passkey methods listPasskeys, createPasskey, getPasskey, updatePasskey, deletePasskey and updatePasskeyVerification
  • Added: account.createPasskeyToken and account.updatePasskeyToken for passkey sign-in
  • Added: users.listPasskeys, users.getPasskey, users.updatePasskey and users.deletePasskey
  • Added: project.updatePasskeyPolicy to configure passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto main: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

Limited by an open minor finding: Use the actual endpoint setter in the examples

This release adds passkey response models and account, users, and project service methods for passkey registration, authentication, management, and policy configuration. It also updates the SDK version metadata and adds usage examples for the new APIs.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Use the actual endpoint setter in the examples docs/examples/account/create-passkey-token.md:7
Fix with agent prompt
### Issue 1
docs/examples/account/create-passkey-token.md:7
**Use the actual endpoint setter in the examples**

The newly added snippets call `SetEndPoint`, but `Client` exposes `SetEndpoint` (see `Appwrite/Client.cs:110`). As written, these examples fail to compile; the same spelling appears across the new account, users, and project examples.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 4
File Change
Appwrite/Appwrite.csproj, Appwrite/Client.cs, README.md, CHANGELOG.md Bumps the SDK package and client version to 8.3.0 and records the release changes.
Appwrite/Models/Passkey.cs, Appwrite/Models/PasskeyList.cs, Appwrite/Models/PasskeyChallenge.cs, Appwrite/Models/TokenSecret.cs Adds response models for passkeys, challenges, lists, and token secrets.
Appwrite/Services/Account.cs, Appwrite/Services/Users.cs, Appwrite/Services/Project.cs Adds passkey account, user-management, sign-in, and project-policy methods.
docs/examples/account/*.md, docs/examples/users/*.md, docs/examples/project/update-passkey-policy.md Adds C# snippets demonstrating the new passkey APIs.
🔇 Filtered out · 1

Findings Hansi considered but did not post.

Finding Why
Allow passkeyId to be absent on sign-in challenges Verifier: CreatePasskeyToken does call PasskeyChallenge.From (Account.cs:2214-2240), and null or missing passkeyId would throw. However, no response fixture, schema, or server implementation in this repository establishes that sign-in challenges actually return null or omit this field. The username-less flow documented at Account.cs:2205-2211 does not establish its wire representation; an empty string would pass this mapper. The finding depends on an unverified response shape.

Reviewed cdd3845 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

using Appwrite.Services;

Client client = new Client()
.SetEndPoint("https://<REGION>.cloud.appwrite.io/v1") // Your API Endpoint

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the actual endpoint setter in the examples

The newly added snippets call SetEndPoint, but Client exposes SetEndpoint (see Appwrite/Client.cs:110). As written, these examples fail to compile; the same spelling appears across the new account, users, and project examples.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/account/create-passkey-token.md
Line: 7

Comment:
**Use the actual endpoint setter in the examples**

The newly added snippets call `SetEndPoint`, but `Client` exposes `SetEndpoint` (see `Appwrite/Client.cs:110`). As written, these examples fail to compile; the same spelling appears across the new account, users, and project examples.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit e8b15b4 into main Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant