Skip to content

feat: Console SDK update for version 19.0.0 - #119

Closed
ChiragAgg5k wants to merge 3 commits into
mainfrom
dev
Closed

ChiragAgg5k wants to merge 3 commits into
mainfrom
dev

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the Console SDK for version 19.0.0.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The response-default wrapper drops the BigInt-safe serialization behavior on affected API results, a minor compatibility issue.

Updates the Console SDK to target Appwrite 2.4 and adds passkey, analytics, tracking, and admin threat/cache APIs. It also refreshes the generated models, enums, examples, and response defaults for the 19.0.0 release.

36 of 117 changed files were too large to include in full.

Verdict New comments Fixed Still open
💬 Commented 1 0 0

Note

Not approving while a bug finding is open: Preserve the response's BigInt-safe toString

Finding Where
🟡 Preserve the response's BigInt-safe toString src/client.ts:83
Fix with agent prompt
### Issue 1
src/client.ts:83
**Preserve the response's BigInt-safe `toString`**

`Client.call` installs a non-enumerable `toString` that serializes with `JSONbig`, but this spread drops it for every model passed through `applyDefaults`. Calling `toString()` on these returned responses (including nested models) now yields `[object Object]`, removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 4
File Change
src/client.ts Adds recursive response-default filling and updates SDK/server version headers.
src/services/* Adds the new API services and methods, updates generated endpoints and response models, and migrates flattening to Client.
src/models.ts, src/enums/*, src/index.ts Adds analytics, passkey, threat, and resource types and exports the new SDK surface.
README.md, CHANGELOG.md, docs/examples/*, package.json Documents the 19.0.0 release and adds or updates API examples.

Reviewed cfb4edb · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Comment thread src/client.ts
if (Array.isArray(value)) {
return value;
}
const result: Record<string, unknown> = { ...model.defaults, ...value };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserve the response's BigInt-safe toString

Client.call installs a non-enumerable toString that serializes with JSONbig, but this spread drops it for every model passed through applyDefaults. Calling toString() on these returned responses (including nested models) now yields [object Object], removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/client.ts
Line: 83

Comment:
**Preserve the response's BigInt-safe `toString`**

`Client.call` installs a non-enumerable `toString` that serializes with `JSONbig`, but this spread drops it for every model passed through `applyDefaults`. Calling `toString()` on these returned responses (including nested models) now yields `[object Object]`, removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · bug · Reply if this doesn't apply.

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Superseded: replaced by a passkeys-only minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants