Repository navigation
feat: Console SDK update for version 19.0.0 - #119
ChiragAgg5k wants to merge 3 commits into
Conversation
🔵 Tier A · Mergeable after minor fixes
Updates the Console SDK to target Appwrite 2.4 and adds passkey, analytics, tracking, and admin threat/cache APIs. It also refreshes the generated models, enums, examples, and response defaults for the 19.0.0 release. 36 of 117 changed files were too large to include in full.
Note Not approving while a bug finding is open: Preserve the response's BigInt-safe
Fix with agent prompt### Issue 1
src/client.ts:83
**Preserve the response's BigInt-safe `toString`**
`Client.call` installs a non-enumerable `toString` that serializes with `JSONbig`, but this spread drops it for every model passed through `applyDefaults`. Calling `toString()` on these returned responses (including nested models) now yields `[object Object]`, removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 4
Reviewed |
| if (Array.isArray(value)) { | ||
| return value; | ||
| } | ||
| const result: Record<string, unknown> = { ...model.defaults, ...value }; |
There was a problem hiding this comment.
Preserve the response's BigInt-safe toString
Client.call installs a non-enumerable toString that serializes with JSONbig, but this spread drops it for every model passed through applyDefaults. Calling toString() on these returned responses (including nested models) now yields [object Object], removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/client.ts
Line: 83
Comment:
**Preserve the response's BigInt-safe `toString`**
`Client.call` installs a non-enumerable `toString` that serializes with `JSONbig`, but this spread drops it for every model passed through `applyDefaults`. Calling `toString()` on these returned responses (including nested models) now yields `[object Object]`, removing the safe serialization path for BigInt fields; please preserve or reinstall it on the copied objects.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
|
Superseded: replaced by a passkeys-only minor release. |
This PR contains updates to the Console SDK for version 19.0.0.