Skip to content

feat: SDK update for version 18.3.0 - #118

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/18.3.0
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/18.3.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 18.3.0.

What's Changed

  • Added: optional interval parameter on Functions.create, Functions.update and Projects.createSchedule
  • Updated: schedule is optional on Projects.createSchedule; pass either schedule or interval
  • Added: interval on the Function and Schedule models, functionsIntervalMinimum on BillingPlan

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The changes have two minor issues: schedule creation accepts neither scheduling mode, and the updated examples combine mutually exclusive modes.

This release updates the console SDK to version 18.3.0 and adds interval scheduling parameters for functions and project schedules. It also exposes interval and billing minimum metadata in the models and updates the associated examples and release documentation.

Verdict New comments Fixed Still open
💬 Commented 2 0 0

Note

Not approving while a bug finding is open: Require at least one scheduling mode

Finding Where
🟡 Require at least one scheduling mode src/services/projects.ts:584
🟡 The example combines mutually exclusive schedule options docs/examples/projects/create-schedule.md:17
Fix with agent prompt
### Issue 1
src/services/projects.ts:584
**Require at least one scheduling mode**

With both `schedule` and `interval` optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.

### Issue 2
docs/examples/projects/create-schedule.md:17
**The example combines mutually exclusive schedule options**

This example sends both `schedule` and `interval`, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 10
File Change
CHANGELOG.md Documents the 18.3.0 scheduling and model additions.
README.md Updates the CDN example to use version 18.3.0.
docs/examples/functions/create.md Adds the interval parameter to the function creation example.
docs/examples/functions/update.md Adds the interval parameter to the function update example.
docs/examples/projects/create-schedule.md Adds interval to the project schedule example and marks schedule optional.
package.json Bumps the package version to 18.3.0.
src/client.ts Updates the SDK version header.
src/models.ts Adds interval and billing interval minimum fields to models.
src/services/functions.ts Adds interval support to function create and update methods.
src/services/projects.ts Adds interval support and makes schedule optional for schedule creation.

Reviewed 37b2645 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Comment thread src/services/projects.ts
resourceType: ScheduleResourceType;
resourceId: string;
schedule: string;
schedule?: string;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require at least one scheduling mode

With both schedule and interval optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/projects.ts
Line: 584

Comment:
**Require at least one scheduling mode**

With both `schedule` and `interval` optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · bug · Reply if this doesn't apply.

schedule: '0 0 * * *', // optional
active: false, // optional
data: {}, // optional
interval: 0, // optional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example combines mutually exclusive schedule options

This example sends both schedule and interval, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/projects/create-schedule.md
Line: 17

Comment:
**The example combines mutually exclusive schedule options**

This example sends both `schedule` and `interval`, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

@hansi-codes please approve

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

I can’t approve this as-is; both findings remain valid:

Please validate that one mode is supplied and update the examples to show only one.

@ChiragAgg5k
ChiragAgg5k merged commit bccd167 into main Oct 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the release/18.3.0 branch October 9, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants