Repository navigation
feat: SDK update for version 18.3.0 - #118
Conversation
🔵 Tier A · Mergeable after minor fixes
This release updates the console SDK to version 18.3.0 and adds interval scheduling parameters for functions and project schedules. It also exposes interval and billing minimum metadata in the models and updates the associated examples and release documentation.
Note Not approving while a bug finding is open: Require at least one scheduling mode
Fix with agent prompt### Issue 1
src/services/projects.ts:584
**Require at least one scheduling mode**
With both `schedule` and `interval` optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.
### Issue 2
docs/examples/projects/create-schedule.md:17
**The example combines mutually exclusive schedule options**
This example sends both `schedule` and `interval`, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 10
Reviewed |
| resourceType: ScheduleResourceType; | ||
| resourceId: string; | ||
| schedule: string; | ||
| schedule?: string; |
There was a problem hiding this comment.
Require at least one scheduling mode
With both schedule and interval optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/projects.ts
Line: 584
Comment:
**Require at least one scheduling mode**
With both `schedule` and `interval` optional, a call that omits both passes the remaining local checks and sends a request without a scheduling mode. The documented contract requires one or the other, so this now defers the missing-parameter error to the API; please validate that at least one is provided.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
| schedule: '0 0 * * *', // optional | ||
| active: false, // optional | ||
| data: {}, // optional | ||
| interval: 0, // optional |
There was a problem hiding this comment.
The example combines mutually exclusive schedule options
This example sends both schedule and interval, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/projects/create-schedule.md
Line: 17
Comment:
**The example combines mutually exclusive schedule options**
This example sends both `schedule` and `interval`, even though the method documentation says they cannot be combined, so copying it produces a rejected request. The function create and update examples have the same combination; please show only one scheduling mode in each example.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
|
@hansi-codes please approve |
|
I can’t approve this as-is; both findings remain valid:
Please validate that one mode is supplied and update the examples to show only one. |
This PR contains updates to the SDK for version 18.3.0.
What's Changed
intervalparameter onFunctions.create,Functions.updateandProjects.createSchedulescheduleis optional onProjects.createSchedule; pass eitherscheduleorintervalintervalon theFunctionandSchedulemodels,functionsIntervalMinimumonBillingPlan