Repository navigation
feat: add deno 2.9, python 3.15, go 1.27 and rust 1.99 runtimes - #114
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🔵 Tier A · Mergeable after minor fixes
Registers Deno 2.9, Python 3.15, Go 1.27, and Rust 1.99 in the runtime catalog with their base images, published image tags, and supported architectures. The new entries are added alongside their existing language runtime versions.
Fix with agent prompt### Issue 1
src/Runtimes/Runtimes.php:83
**Add assertions for the new runtime entries**
Could you pin the expected keys and metadata for these additions in `RuntimesTest`? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 1
Reviewed |
| $python->addVersion('3.12', 'python:3.12.6-alpine3.20', 'openruntimes/python:'.$this->version.'-3.12', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]); | ||
| $python->addVersion('3.13', 'python:3.13.11-alpine3.23', 'openruntimes/python:'.$this->version.'-3.13', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]); | ||
| $python->addVersion('3.14', 'python:3.14.2-alpine3.23', 'openruntimes/python:'.$this->version.'-3.14', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]); | ||
| $python->addVersion('3.15', 'python:3.15.1-alpine3.24', 'openruntimes/python:'.$this->version.'-3.15', [System::X86, System::ARM64]); |
There was a problem hiding this comment.
Add assertions for the new runtime entries
Could you pin the expected keys and metadata for these additions in RuntimesTest? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Runtimes/Runtimes.php
Line: 83
Comment:
**Add assertions for the new runtime entries**
Could you pin the expected keys and metadata for these additions in `RuntimesTest`? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
Registers the runtime lines added in open-runtimes #583, shipped in release 0.13.33. One line per runtime, directly under the previous version.
supportsmatches what open-runtimes builds and publishes for each target (amd64+arm64, checked against the published manifests), sopython-3.15doesn't copy the ARMV7/ARMV8 claim from the 3.14 line.Rust 1.99 is added next to 1.83, which keeps publishing
openruntimes/rust:v5-1.83.These keys are already allowlisted on staging (appwrite-labs/application-configuration#747, merged) and production (#757), but they only show up in the console once this is tagged and pulled into
appwriteandcloud.Verification