Skip to content

feat: add deno 2.9, python 3.15, go 1.27 and rust 1.99 runtimes - #114

Merged
levivannoort merged 1 commit into
mainfrom
feat/deno-2.9-python-3.15-go-1.27-rust-1.99
Oct 22, 2026
Merged

levivannoort merged 1 commit into
mainfrom
feat/deno-2.9-python-3.15-go-1.27-rust-1.99

Conversation

@levivannoort

Copy link
Copy Markdown
Member

Registers the runtime lines added in open-runtimes #583, shipped in release 0.13.33. One line per runtime, directly under the previous version.

$python->addVersion('3.15', 'python:3.15.1-alpine3.24', 'openruntimes/python:'.$this->version.'-3.15', [System::X86, System::ARM64]);
$deno->addVersion('2.9', 'denoland/deno:alpine-2.9.8', 'openruntimes/deno:'.$this->version.'-2.9', [System::X86, System::ARM64]);
$go->addVersion('1.27', 'golang:1.27.3-alpine3.24', 'openruntimes/go:'.$this->version.'-1.27', [System::X86, System::ARM64]);
$rust->addVersion('1.99', 'rust:1.99.1-alpine3.24', 'openruntimes/rust:'.$this->version.'-1.99', [System::X86, System::ARM64]);

supports matches what open-runtimes builds and publishes for each target (amd64 + arm64, checked against the published manifests), so python-3.15 doesn't copy the ARMV7/ARMV8 claim from the 3.14 line.

Rust 1.99 is added next to 1.83, which keeps publishing openruntimes/rust:v5-1.83.

These keys are already allowlisted on staging (appwrite-labs/application-configuration#747, merged) and production (#757), but they only show up in the console once this is tagged and pulled into appwrite and cloud.

Verification

$ php -l src/Runtimes/Runtimes.php
No syntax errors detected

$ php -r '... (new Runtimes("v5"))->getAll() ...'
deno-2.9 ok openruntimes/deno:v5-2.9
python-3.15 ok openruntimes/python:v5-3.15
go-1.27 ok openruntimes/go:v5-1.27
rust-1.99 ok openruntimes/rust:v5-1.99

$ vendor/bin/phpunit
OK (11 tests, 1220 assertions)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hansi-codes

hansi-codes Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The new registrations appear consistent, with a minor gap in tests for their specific metadata.

Registers Deno 2.9, Python 3.15, Go 1.27, and Rust 1.99 in the runtime catalog with their base images, published image tags, and supported architectures. The new entries are added alongside their existing language runtime versions.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Add assertions for the new runtime entries src/Runtimes/Runtimes.php:83
Fix with agent prompt
### Issue 1
src/Runtimes/Runtimes.php:83
**Add assertions for the new runtime entries**

Could you pin the expected keys and metadata for these additions in `RuntimesTest`? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 1
File Change
src/Runtimes/Runtimes.php Adds the four runtime version records and their architecture support lists.

Reviewed 03ecf7b · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment thread src/Runtimes/Runtimes.php
$python->addVersion('3.12', 'python:3.12.6-alpine3.20', 'openruntimes/python:'.$this->version.'-3.12', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]);
$python->addVersion('3.13', 'python:3.13.11-alpine3.23', 'openruntimes/python:'.$this->version.'-3.13', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]);
$python->addVersion('3.14', 'python:3.14.2-alpine3.23', 'openruntimes/python:'.$this->version.'-3.14', [System::X86, System::ARM64, System::ARMV7, System::ARMV8]);
$python->addVersion('3.15', 'python:3.15.1-alpine3.24', 'openruntimes/python:'.$this->version.'-3.15', [System::X86, System::ARM64]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add assertions for the new runtime entries

Could you pin the expected keys and metadata for these additions in RuntimesTest? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Runtimes/Runtimes.php
Line: 83

Comment:
**Add assertions for the new runtime entries**

Could you pin the expected keys and metadata for these additions in `RuntimesTest`? Its existing runtime-list test checks generic shape and nonempty support lists, so an incorrect image tag or architecture list for these new entries would still pass.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@levivannoort
levivannoort merged commit d2da669 into main Oct 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant