Skip to content

feat: browser on by default - #24

Merged
levivannoort merged 2 commits into
mainfrom
feat/browser-by-default
Oct 14, 2026
Merged

levivannoort merged 2 commits into
mainfrom
feat/browser-by-default

Conversation

@levivannoort

@levivannoort levivannoort commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

What

Sites are on by default since 2.0.0, and Appwrite takes a screenshot of every site deployment through the browser service, which was off by default (browser.enabled: false). On a default install every site deployment therefore ends with:

[appwrite] Screenshot capturing started.
[appwrite] Screenshot capturing failed. Deployment will continue.

and the console shows "No preview". The screenshots worker logs Could not resolve host: appwrite-browser (Domain name not found). Found on a fresh 2.0.0 install on kind, deploying the TanStack Start starter. Appwrite's Docker install runs the browser by default too.

  • browser.enabled defaults to true. It requests 100m CPU and 512Mi, with a 2Gi limit.
  • docs/optional-components.md: Geo and the browser are on by default, and the browser section shows how to turn it off and what happens without it.
  • docs/troubleshooting.md: Site deployments log "Screenshot capturing failed" covers the browser being off, or its egress policy.
  • Unit test: the browser deploys by default; the other optional components still don't.
  • CHANGELOG.md [Unreleased]: Changed and Added. A new default, not a breaking change, so this is for 2.1.0 (release in a separate PR, based on main after this merges).

Testing

  • make test passes: 247/247 unit tests, lint, kubeconform, examples, generated files.
  • Every CI install scenario now runs the browser, and hack/smoke.sh takes a screenshot through it when its Service exists.
  • Not yet checked by hand: a site redeployed on the local 2.0.0 install with the browser on.

Sites are on by default since 2.0.0, and Appwrite takes a screenshot of every
site deployment through the browser service, which was off by default: each
site deployment then logged "Screenshot capturing failed" (the screenshots
worker can't resolve appwrite-browser) and the console showed no preview.
Appwrite's Docker install runs the browser by default too.

The optional-components guide says so, troubleshooting covers the failed
screenshot (browser off, or its egress policy), and every CI install now
also runs hack/smoke.sh's screenshot check.
@hansi-codes

hansi-codes Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The revised selector matches worker pods in all documented modes, including separate and grouped deployments, so the earlier log-command issue is resolved and no new defect is apparent.

Enables the browser by default so Site deployments can capture previews, and adds a default-deployment test, changelog entry, and updated generated chart documentation. The optional-components guide explains the browser default and how to disable it, while troubleshooting guidance covers screenshot failures and locating their worker logs across worker modes.

Latest changes: The latest commit changes the screenshot troubleshooting command to find worker logs by label across combined, separate, and grouped modes, and clarifies which worker emits the cause.

Verdict New comments Fixed Still open
✅ Approved 0 1 0
📂 Walkthrough · 7
File Change
CHANGELOG.md Records the browser default change and screenshot troubleshooting addition.
charts/appwrite/README.md Regenerates the chart reference documentation for the browser default.
charts/appwrite/tests/optional_test.yaml Tests that the browser deploys by default while other optional components remain disabled.
charts/appwrite/values.schema.json Regenerates the schema description for the browser setting.
charts/appwrite/values.yaml Enables the browser by default and documents its resource settings and purpose.
docs/optional-components.md Documents the browser's default-on behavior and how to disable it.
docs/troubleshooting.md Adds screenshot failure guidance and a worker-label log command that works across worker modes.
✅ Fixed since the last review · 1
  • Log command only works with combined workers · docs/troubleshooting.md:330

Reviewed the commits since 46589f9 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment thread docs/troubleshooting.md Outdated
deploy/appwrite-worker only exists with workers.mode combined; select the
worker pods by their appwrite/role label instead, with enough --tail for a
selector (which defaults to 10 lines per pod).

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@levivannoort
levivannoort merged commit 5550a65 into main Oct 14, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant