Repository navigation
feat: browser on by default - #24
Conversation
Sites are on by default since 2.0.0, and Appwrite takes a screenshot of every site deployment through the browser service, which was off by default: each site deployment then logged "Screenshot capturing failed" (the screenshots worker can't resolve appwrite-browser) and the console showed no preview. Appwrite's Docker install runs the browser by default too. The optional-components guide says so, troubleshooting covers the failed screenshot (browser off, or its egress policy), and every CI install now also runs hack/smoke.sh's screenshot check.
🟢 Tier S · Ready to merge
Enables the browser by default so Site deployments can capture previews, and adds a default-deployment test, changelog entry, and updated generated chart documentation. The optional-components guide explains the browser default and how to disable it, while troubleshooting guidance covers screenshot failures and locating their worker logs across worker modes. Latest changes: The latest commit changes the screenshot troubleshooting command to find worker logs by label across combined, separate, and grouped modes, and clarifies which worker emits the cause.
📂 Walkthrough · 7
✅ Fixed since the last review · 1
Reviewed the commits since |
deploy/appwrite-worker only exists with workers.mode combined; select the worker pods by their appwrite/role label instead, with enough --tail for a selector (which defaults to 10 lines per pod).
What
Sites are on by default since 2.0.0, and Appwrite takes a screenshot of every site deployment through the browser service, which was off by default (
browser.enabled: false). On a default install every site deployment therefore ends with:and the console shows "No preview". The screenshots worker logs
Could not resolve host: appwrite-browser (Domain name not found). Found on a fresh 2.0.0 install on kind, deploying the TanStack Start starter. Appwrite's Docker install runs the browser by default too.browser.enableddefaults totrue. It requests 100m CPU and 512Mi, with a 2Gi limit.docs/optional-components.md: Geo and the browser are on by default, and the browser section shows how to turn it off and what happens without it.docs/troubleshooting.md: Site deployments log "Screenshot capturing failed" covers the browser being off, or its egress policy.CHANGELOG.md[Unreleased]: Changed and Added. A new default, not a breaking change, so this is for 2.1.0 (release in a separate PR, based onmainafter this merges).Testing
make testpasses: 247/247 unit tests, lint, kubeconform, examples, generated files.hack/smoke.shtakes a screenshot through it when its Service exists.